Skip to content

fix(p2p): remove BlockAssemblyDetails from node status#68

Closed
ordishs wants to merge 27 commits into
bsv-blockchain:mainfrom
ordishs:fix/remove-subtrees-from-nodeStatus
Closed

fix(p2p): remove BlockAssemblyDetails from node status#68
ordishs wants to merge 27 commits into
bsv-blockchain:mainfrom
ordishs:fix/remove-subtrees-from-nodeStatus

Conversation

@ordishs

@ordishs ordishs commented Oct 28, 2025

Copy link
Copy Markdown
Collaborator

Summary

  • Remove BlockAssemblyDetails from P2P node status notifications to prevent nil pointer panics
  • Fix SQL column mismatch in block header queries
  • Correct BlockHeaderMeta serialization and add ProcessedAt support
  • UI improvements: add tooltips, copy functionality for invalidated blocks, and clear sort button

Test plan

  • Verify P2P node status no longer causes nil pointer panics
  • Confirm block header queries work correctly
  • Test BlockHeaderMeta serialization with ProcessedAt field
  • Verify UI improvements in dashboard (tooltips, copy, sort functionality)
  • Run smoke tests to ensure no regressions

ordishs and others added 27 commits October 15, 2025 11:51
… support

- Fix capacity calculation in BlockHeaderMeta.Bytes() to include all fields
- Add ProcessedAt field to BlockHeaderMeta struct for tracking block processing time
- Update serialization/deserialization to handle ProcessedAt timestamp (8 bytes)
- Add ProcessedAt to protobuf GetBlockHeaderResponse with proper timestamp type conversion
- Update HTTP API responses to include Invalid and ProcessedAt fields
- Fix frontend date parsing to handle RFC 3339 timestamp format from JSON API
- Add hasCoinbaseColumn parameter to processBlockHeadersRows
- Fix GetBlockHeadersFromOldest to include processed_at column
- Remove dynamic column detection to improve performance
- Fix variable shadowing with err declaration
…ions

Replace detailed block assembly state with simpler subtree_count field
in websocket notifications to reduce message size and coupling
Add icon button to clear sorting on network nodes table and ensure
current node appears at top only when no user sorting is active
Keep ancestors page accessible via direct URL but remove from menu
Replace custom hash rendering with reusable RenderHashWithMiner component
to provide consistent tooltip display and copy-to-clipboard functionality
across the admin page's recently invalidated blocks table.
…l pointer panic

Remove BlockAssemblyDetails field from NodeStatusMessage struct and eliminate
attempts to access SubtreeCount/TxCount fields that caused segmentation fault
in handleNodeStatusTopic. Also remove unused blockassembly_api import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants