Include unresolved symlink target into the source directory hash #25864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Stacked on #25859 |
3e2fb54 to
8c1c32f
Compare
Collaborator
Author
|
@tjgq I also added the missing BUILD target here so that the new test actually runs. |
8c1c32f to
11d791b
Compare
This makes it so that changes to the targets of unresolved symlinks invalidate actions that depend on the source directory containing them. # Conflicts: # src/test/java/com/google/devtools/build/lib/skyframe/SourceDirectoryIntegrationTest.java
# Conflicts: # src/test/java/com/google/devtools/build/lib/skyframe/BUILD
11d791b to
2418d60
Compare
Collaborator
Author
|
@tjgq I fixed the conflict, this is ready for another review. |
Member
|
Can you please rebase again, the test failures should be fixed at HEAD. |
Collaborator
Author
|
@meteorcloudy done! |
tjgq
approved these changes
May 19, 2025
Collaborator
Author
|
@bazel-io fork 8.3.0 |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 20, 2025
This makes it so that changes to the targets of unresolved symlinks invalidate actions that depend on the source directory containing them. Work towards bazelbuild#25834 Closes bazelbuild#25864. PiperOrigin-RevId: 760968335 Change-Id: I09c250eb8e7d147006a4e6fdc33a372ce7277bc0
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 25, 2025
This makes it so that changes to the targets of unresolved symlinks invalidate actions that depend on the source directory containing them. Work towards bazelbuild#25834 Closes bazelbuild#25864. PiperOrigin-RevId: 760968335 Change-Id: I09c250eb8e7d147006a4e6fdc33a372ce7277bc0 (cherry picked from commit a3b5836)
dd-mergequeue bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Jan 15, 2026
### What does this PR do? Bump `bazel` version from [8.4.2](https://github.com/bazelbuild/bazel/releases/tag/8.4.2) to [8.5.1](https://github.com/bazelbuild/bazel/releases/tag/8.5.1). To make that happen, we also need to: - specify which `bash` to use on Windows when evaluating **repository** rules, for compatibility with bazelbuild/bazel#26927: ``` ERROR: /path/to/external/bazel_tools/tools/test/BUILD:23:10: in sh_binary rule @@bazel_tools//tools/test:collect_coverage: Error in fail: No suitable shell toolchain found: * if you are running Bazel on Windows, set the BAZEL_SH environment variable to the path of bash.exe ``` (actual job output: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1349246422#L77) - bump `rules_go` from (implicit) [0.57.0](https://github.com/bazel-contrib/rules_go/releases/tag/v0.57.0) to (explicit) [0.59.0](https://github.com/bazel-contrib/rules_go/releases/tag/v0.59.0) for bazel-contrib/rules_go/pull/4493 to be compatible with bazelbuild/bazel/pull/27296: ``` Error: 'Facts' value has no field or method 'clear' ``` ### Motivation 1. this upgrade alone brings several improvements and bug fixes, among which: - bazelbuild/bazel#27117 - bazelbuild/bazel#27296 - bazelbuild/bazel#27417, covers: - bazelbuild/bazel#25834 - bazelbuild/bazel#25863 - bazelbuild/bazel#25864 - bazelbuild/bazel#25870 - bazelbuild/bazel#26698 - bazelbuild/bazel#27531 - bazelbuild/bazel#27560 - bazelbuild/bazel#27564 - bazelbuild/bazel#27705 - bazelbuild/bazel#27995 - bazelbuild/bazel#27996 2. `bazel` 9.0 is due soon, so better off favoring incremental bumps. ### Additional Notes Leveraging [the latter](bazelbuild/bazel#27996) might allow us to later reconsider whether we'd like to go back to the `--remote_cache` flag (instead of the `--remote_executor` flag that we had to switch to in #44962). Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that changes to the targets of unresolved symlinks invalidate actions that depend on the source directory containing them.
Work towards #25834