Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 15, 2025

The new test subsumes an existing test that focused on empty directories as well as a shell test for package boundary handling.

Work towards #25834

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 15, 2025
@fmeum fmeum force-pushed the 25834-source-directories branch from f921bb8 to 6de5b6c Compare April 15, 2025 16:05
@fmeum fmeum force-pushed the 25834-source-directories branch from 6de5b6c to 3aae024 Compare April 15, 2025 16:06
@fmeum fmeum requested review from Copilot and tjgq April 15, 2025 16:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/test/java/com/google/devtools/build/lib/skyframe/BUILD: Language not supported

@fmeum fmeum force-pushed the 25834-source-directories branch from 3ae0001 to ee21f1b Compare April 16, 2025 10:43
@iancha1992 iancha1992 added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Apr 16, 2025
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 29, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 30, 2025
@fmeum fmeum deleted the 25834-source-directories branch May 19, 2025 13:21
@fmeum
Copy link
Collaborator Author

fmeum commented May 19, 2025

@bazel-io fork 8.3.0

iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request May 19, 2025
The new test subsumes an existing test that focused on empty directories as well as a shell test for package boundary handling.

Work towards bazelbuild#25834

Closes bazelbuild#25859.

PiperOrigin-RevId: 753094192
Change-Id: Ia341aeb56fcdad74c8806ff0e2994580e829d735
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2025
The new test subsumes an existing test that focused on empty directories
as well as a shell test for package boundary handling.

Work towards #25834

Closes #25859.

PiperOrigin-RevId: 753094192
Change-Id: Ia341aeb56fcdad74c8806ff0e2994580e829d735

Commit
ad381cb

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Core Skyframe, bazel query, BEP, options parsing, bazelrc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants