Track source directory contents by default #25870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e92da87 to
f9a3684
Compare
640d4ae to
29f481d
Compare
fmeum
commented
May 20, 2025
|
|
||
| /** | ||
| * A flag to enable / disable tracking of source directories. Uses a system property which can be | ||
| * set via a startup flag. The intention is for this code to be temporary, so I didn't want to add |
Collaborator
Author
There was a problem hiding this comment.
I can update this comment, but as I don't know the situation at Google, I would need suggestions from you.
This was referenced Aug 4, 2025
Collaborator
Author
|
@tjgq I rebased onto master. |
# Conflicts: # src/test/java/com/google/devtools/build/lib/skyframe/BUILD # src/test/shell/integration/execution_phase_tests.sh
59b9078 to
9e5253b
Compare
tjgq
requested changes
Aug 7, 2025
tjgq
approved these changes
Aug 25, 2025
Contributor
|
LGTM, but it probably won't get submitted before next week (I want to get an ack from a couple of folks who are currently OOO). |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 25, 2025
Preparation for bazelbuild#25870 Closes bazelbuild#26698. PiperOrigin-RevId: 792236653 Change-Id: Iaf10cc32c4938987a6afef1b73081666963435b2 (cherry picked from commit f12e843)
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 25, 2025
RELNOTES: The contents of source directories are now tracked for invalidation. Using `glob` or explicit lists of files to consume source directories is still strongly preferred, but there may be cases in which this isn't feasible (e.g. file names that aren't valid labels). Fixes bazelbuild#25834 Closes bazelbuild#25870. PiperOrigin-RevId: 803387098 Change-Id: Ibf9ecf86289226c3cde1b09a802c61451b02bfba (cherry picked from commit a36ce44)
dd-mergequeue bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Jan 15, 2026
### What does this PR do? Bump `bazel` version from [8.4.2](https://github.com/bazelbuild/bazel/releases/tag/8.4.2) to [8.5.1](https://github.com/bazelbuild/bazel/releases/tag/8.5.1). To make that happen, we also need to: - specify which `bash` to use on Windows when evaluating **repository** rules, for compatibility with bazelbuild/bazel#26927: ``` ERROR: /path/to/external/bazel_tools/tools/test/BUILD:23:10: in sh_binary rule @@bazel_tools//tools/test:collect_coverage: Error in fail: No suitable shell toolchain found: * if you are running Bazel on Windows, set the BAZEL_SH environment variable to the path of bash.exe ``` (actual job output: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1349246422#L77) - bump `rules_go` from (implicit) [0.57.0](https://github.com/bazel-contrib/rules_go/releases/tag/v0.57.0) to (explicit) [0.59.0](https://github.com/bazel-contrib/rules_go/releases/tag/v0.59.0) for bazel-contrib/rules_go/pull/4493 to be compatible with bazelbuild/bazel/pull/27296: ``` Error: 'Facts' value has no field or method 'clear' ``` ### Motivation 1. this upgrade alone brings several improvements and bug fixes, among which: - bazelbuild/bazel#27117 - bazelbuild/bazel#27296 - bazelbuild/bazel#27417, covers: - bazelbuild/bazel#25834 - bazelbuild/bazel#25863 - bazelbuild/bazel#25864 - bazelbuild/bazel#25870 - bazelbuild/bazel#26698 - bazelbuild/bazel#27531 - bazelbuild/bazel#27560 - bazelbuild/bazel#27564 - bazelbuild/bazel#27705 - bazelbuild/bazel#27995 - bazelbuild/bazel#27996 2. `bazel` 9.0 is due soon, so better off favoring incremental bumps. ### Additional Notes Leveraging [the latter](bazelbuild/bazel#27996) might allow us to later reconsider whether we'd like to go back to the `--remote_cache` flag (instead of the `--remote_executor` flag that we had to switch to in #44962). Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELNOTES: The contents of source directories are now tracked for invalidation. Using
globto consume source directories is still strongly preferred, but there may be cases in which this isn't feasible (e.g. file names that aren't valid labels).Fixes #25834