fix: load CcSharedLibraryInfo from rules_cc for Bazel 9#1493
Merged
novas0x2a merged 2 commits intobazel-contrib:mainfrom Mar 19, 2026
Merged
fix: load CcSharedLibraryInfo from rules_cc for Bazel 9#1493novas0x2a merged 2 commits intobazel-contrib:mainfrom
CcSharedLibraryInfo from rules_cc for Bazel 9#1493novas0x2a merged 2 commits intobazel-contrib:mainfrom
Conversation
Collaborator
|
Seems fine, except buildifier is angry with you |
This is to make `rules_foreign_cc` consumable with Bazel 9 where `cc_external_rule_impl` currently fails on: ``` Error in fail: CcSharedLibraryInfo is only available in Bazel 7 or greater ``` The guard was relying on `bazel_features.globals.CcSharedLibraryInfo` to detect provider availability. In Bazel 9, `bazel_features` computes this via `native.legacy_globals.CcSharedLibraryInfo`, which is `None` because the symbol was removed from the `native` namespace. `CcSharedLibraryInfo` has been available in `@rules_cc` since 0.1.0, which predates the minimum `rules_cc` version required by `rules_foreign_cc`. Loading it directly from `@rules_cc//cc/common:cc_shared_library_info.bzl` makes the guard unnecessary and should satisfy all Bazel versions.
ba952e9 to
be20551
Compare
Contributor
Author
@novas0x2a Sorry - I just removed the (now) unused |
novas0x2a
pushed a commit
that referenced
this pull request
Mar 19, 2026
This is a first step toward making `rules_foreign_cc` _buildable_ with Bazel 9 (making it _consumable_ with Bazel 9 deserves a dedicated [fix](#1493)). Running `bazel build -k //...` on Bazel 9.0.1 produces a flood of errors like: ``` ERROR: .../rules_go+/go/private/rules/cgo.bzl:101:12: The CcInfo symbol has been removed, add the following to your BUILD/bzl file: load("@rules_cc//cc/common:cc_info.bzl", "CcInfo") ``` The root cause is rules_go@0.50.1, pulled in transitively via: - `bazel_skylib_gazelle_plugin@1.7.1` - `gazelle@0.41.0` - `rules_go@0.50.1` That version references `CcInfo` and other `CC*` symbols as Bazel-native globals, removed in Bazel 9. bazel-contrib/rules_go#4508 fixed this in rules_go@0.59.0. Bumping `bazel_skylib_gazelle_plugin` to 1.9.0 is sufficient: its direct dependency on rules_go@0.59.0 overrides the rules_go@0.50.1 required by gazelle@0.41.0, wiping out the entire error class. Since `bazel_skylib_gazelle_plugin` is a **dev** dependency, this only affects building the repo itself, not its consumers. Note: `bazel_skylib` must be bumped as well according to CI failing on: ``` ERROR: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.8.2, but got bazel_skylib@1.9.0 in the resolved dependency graph. ```
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 19, 2026
Moving the unreleased tip of main allows to address Bazel 9 related issues instead of patching locally: - bazel-contrib/rules_foreign_cc#1493 - bazel-contrib/rules_foreign_cc#1492 Other notable commits since: - bazel-contrib/rules_foreign_cc#1483 - bazel-contrib/rules_foreign_cc#1490 - bazel-contrib/rules_foreign_cc#1496 Patches 0002 (DY/LD_LIBRARY_PATH) and 0003 (-j on make command line) are still carried locally as neither has landed upstream yet (but we're working on it).
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 21, 2026
Moving the unreleased tip of main allows to address Bazel 9 related issues instead of patching locally: - bazel-contrib/rules_foreign_cc#1493 - bazel-contrib/rules_foreign_cc#1492 Other notable commits since: - bazel-contrib/rules_foreign_cc#1483 - bazel-contrib/rules_foreign_cc#1490 - bazel-contrib/rules_foreign_cc#1496 Patches 0002 (DY/LD_LIBRARY_PATH) and 0003 (-j on make command line) are still carried locally as neither has landed upstream yet (but we're working on it).
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 21, 2026
Depends on #48082. ### Motivation Moving the unreleased tip of main allows to address Bazel 9 related issues instead of patching locally: - bazel-contrib/rules_foreign_cc#1493 - bazel-contrib/rules_foreign_cc#1492 (`CcInfo` and other `Cc*` symbols) Other notable commits since: - bazel-contrib/rules_foreign_cc#1483 - bazel-contrib/rules_foreign_cc#1490 - bazel-contrib/rules_foreign_cc#1496 ### Additional Notes Patches 0002 (bazel-contrib/rules_foreign_cc#1452) and 0003 (bazel-contrib/rules_foreign_cc#1491) are still carried locally as neither has landed upstream yet (but we're working on it). Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make
rules_foreign_ccconsumable with Bazel 9 wherecc_external_rule_implcurrently fails on:The guard was relying on
bazel_features.globals.CcSharedLibraryInfoto detect provider availability.In Bazel 9,
bazel_featurescomputes this vianative.legacy_globals.CcSharedLibraryInfo, which isNonebecause the symbol was removed from thenativenamespace.CcSharedLibraryInfohas been available in@rules_ccsince 0.1.0, which predates the minimumrules_ccversion required byrules_foreign_cc.Loading it directly from
@rules_cc//cc/common:cc_shared_library_info.bzlmakes the guard unnecessary and should satisfy all Bazel versions.