deps: bump bazel_skylib_gazelle_plugin to 1.9.0 by rdesgroppes · Pull Request #1492 · bazel-contrib/rules_foreign_cc

rdesgroppes · 2026-03-18T15:00:41Z

This is a first step toward making rules_foreign_cc buildable with Bazel 9 (making it consumable with Bazel 9 deserves a dedicated fix).

Running bazel build -k //... on Bazel 9.0.1 produces a flood of errors like:

  ERROR: .../rules_go+/go/private/rules/cgo.bzl:101:12: The CcInfo
  symbol has been removed, add the following to your BUILD/bzl file:
  load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")

The root cause is rules_go@0.50.1, pulled in transitively via:

bazel_skylib_gazelle_plugin@1.7.1
- gazelle@0.41.0
  - rules_go@0.50.1

That version references CcInfo and other Cc* symbols as Bazel-native globals, removed in Bazel 9. bazel-contrib/rules_go#4508 fixed this in rules_go@0.59.0.

Bumping bazel_skylib_gazelle_plugin to 1.9.0 is sufficient: its direct dependency on rules_go@0.59.0 overrides the rules_go@0.50.1 required by gazelle@0.41.0, wiping out the entire error class.

Since bazel_skylib_gazelle_plugin is a dev dependency, this only affects building the repo itself, not its consumers.

Note: bazel_skylib must be bumped as well according to CI failing on:

  ERROR: For repository 'bazel_skylib', the root module requires module
  version bazel_skylib@1.8.2, but got bazel_skylib@1.9.0 in the resolved
  dependency graph.

novas0x2a · 2026-03-19T06:27:25Z

No objection to the bump except that:

don't forget to bump it in all of the other repo modules too (that's what most of the build failures are from)
don't forget to bump the workspace macro versions, too; i'm trying to keep the versions used between bzlmod and workspaces roughly in sync, because it's even harder to reason about otherwise :\

This is a first step toward making `rules_foreign_cc` _buildable_ with Bazel 9 (making it _consumable_ deserves a dedicated fix). Running `bazel build -k //...` on Bazel 9.0.1 produces a flood of errors like: ``` ERROR: .../rules_go+/go/private/rules/cgo.bzl:101:12: The CcInfo symbol has been removed, add the following to your BUILD/bzl file: load("@rules_cc//cc/common:cc_info.bzl", "CcInfo") ``` The root cause is rules_go@0.50.1, pulled in transitively via: - `bazel_skylib_gazelle_plugin@1.7.1` - `gazelle@0.41.0` - `rules_go@0.50.1` That version references `CcInfo` and other `CC*` symbols as Bazel-native globals, removed in Bazel 9. bazel-contrib/rules_go#4508 fixed this in rules_go@0.59.0. Bumping `bazel_skylib_gazelle_plugin` to 1.9.0 is sufficient: its direct dependency on rules_go@0.59.0 overrides the rules_go@0.50.1 required by gazelle@0.41.0, wiping out the entire error class. Since `bazel_skylib_gazelle_plugin` is a **dev** dependency, this only affects building the repo itself, not its consumers. Note: `bazel_skylib` must be bumped as well according to CI failing on: ``` ERROR: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.8.2, but got bazel_skylib@1.9.0 in the resolved dependency graph. ```

Moving the unreleased tip of main allows to address Bazel 9 related issues instead of patching locally: - bazel-contrib/rules_foreign_cc#1493 - bazel-contrib/rules_foreign_cc#1492 Other notable commits since: - bazel-contrib/rules_foreign_cc#1483 - bazel-contrib/rules_foreign_cc#1490 - bazel-contrib/rules_foreign_cc#1496 Patches 0002 (DY/LD_LIBRARY_PATH) and 0003 (-j on make command line) are still carried locally as neither has landed upstream yet (but we're working on it).

Depends on #48082. ### Motivation Moving the unreleased tip of main allows to address Bazel 9 related issues instead of patching locally: - bazel-contrib/rules_foreign_cc#1493 - bazel-contrib/rules_foreign_cc#1492 (`CcInfo` and other `Cc*` symbols) Other notable commits since: - bazel-contrib/rules_foreign_cc#1483 - bazel-contrib/rules_foreign_cc#1490 - bazel-contrib/rules_foreign_cc#1496 ### Additional Notes Patches 0002 (bazel-contrib/rules_foreign_cc#1452) and 0003 (bazel-contrib/rules_foreign_cc#1491) are still carried locally as neither has landed upstream yet (but we're working on it). Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

rdesgroppes force-pushed the bump-bazel_skylib_gazelle_plugin-for-bazel9 branch from a6bcf98 to b057951 Compare March 18, 2026 16:07

novas0x2a self-requested a review March 19, 2026 06:27

rdesgroppes force-pushed the bump-bazel_skylib_gazelle_plugin-for-bazel9 branch from b057951 to 045531f Compare March 19, 2026 07:54

novas0x2a merged commit 389ebcf into bazel-contrib:main Mar 19, 2026
2 checks passed

rdesgroppes mentioned this pull request Mar 19, 2026

Bump rules_foreign_cc for Bazel 9 fixes DataDog/datadog-agent#48071

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: bump bazel_skylib_gazelle_plugin to 1.9.0#1492

deps: bump bazel_skylib_gazelle_plugin to 1.9.0#1492
novas0x2a merged 1 commit intobazel-contrib:mainfrom
rdesgroppes:bump-bazel_skylib_gazelle_plugin-for-bazel9

rdesgroppes commented Mar 18, 2026 •

edited

Loading

Uh oh!

novas0x2a commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rdesgroppes commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

novas0x2a commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rdesgroppes commented Mar 18, 2026 •

edited

Loading