deps: update bazel module and workspace dependency versions#1462
deps: update bazel module and workspace dependency versions#1462novas0x2a merged 1 commit intobazel-contrib:mainfrom
Conversation
f8db645 to
f24c9b5
Compare
There was a problem hiding this comment.
Pull request overview
Updates Bazel module/workspace dependency pins to eliminate bzlmod version skew warnings, align bzlmod and WORKSPACE dependency versions, and adopt the renamed bazel_lib (post-aspect_bazel_lib).
Changes:
- Bump core Bazel deps (
platforms,bazel_features,bazel_skylib,rules_cc,rules_shell) and addbazel_libacross module/workspace configs. - Update WORKSPACE lint tooling to
aspect_rules_lint1.12.0and wire it tobazel_librepositories/toolchains. - Add/update
MODULE.bazel.lockand update documented Bazel compatibility baseline.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| foreign_cc/repositories.bzl | Updates WORKSPACE-mode dependency archives and adds bazel_lib as a repo dependency. |
| examples/MODULE.bazel | Aligns example module deps to updated versions and adds bazel_lib. |
| docs/MODULE.bazel | Aligns docs module deps and adds bazel_lib. |
| WORKSPACE.bazel | Updates aspect_rules_lint version and switches integration to bazel_lib. |
| README.md | Updates stated minimum Bazel version (now matches .bazelversion). |
| MODULE.bazel | Updates bzlmod deps, adds bazel_lib, and bumps aspect_rules_lint. |
| MODULE.bazel.lock | Adds generated bzlmod lockfile reflecting the resolved dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This does a few things: - Resolves all bzlmod warnings of the form "the root module requires module version X, but got Y in the resolved dependency graph." - Fixes the dependency mismatches between bzlmod and workspace versions. - Switches to the post-rename bazel_lib. - Adds/updates MODULE.bazel.lock files.
f24c9b5 to
2d5673e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Bazel versions compatibility | ||
|
|
||
| Works with Bazel after 5.4.0. | ||
| Works with Bazel after 7.4.1. |
There was a problem hiding this comment.
IMO it should always be fine to require the latest minor version of a given Bazel major release.
There was a problem hiding this comment.
Yeah, I agree, though I'm changing so much in this chain of PRs that I was trying to reduce the scope a bit (7.4.1 is what we currently have .bazelversion set to; I think we should probably bump it, though.)
Switch rules_foreign_cc from single_version_override on 0.15.1 to a git_override on main (e4068330) to pick up three upstream fixes: - bazel-contrib/rules_foreign_cc#1451: out_data_dirs in output groups (our patch 0001 verbatim — drop it) - bazel-contrib/rules_foreign_cc#1465: resource_set integration, which lets Bazel's scheduler respect CPU/RAM budgets and avoids build action overcommitting - bazel-contrib/rules_foreign_cc#1470: forward -isystem flags to configure scripts Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. bazel-contrib/rules_foreign_cc#1462 bumps bazel_lib to 3.2.0; follow up to 3.2.2 to get path-mapping compatibility with Bazel 9. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Switch rules_foreign_cc from single_version_override on 0.15.1 to a git_override on main (e4068330) to pick up three upstream fixes: - bazel-contrib/rules_foreign_cc#1451: out_data_dirs in output groups (our patch 0001 verbatim — drop it) - bazel-contrib/rules_foreign_cc#1465: resource_set integration, which lets Bazel's scheduler respect CPU/RAM budgets and avoids build action overcommitting - bazel-contrib/rules_foreign_cc#1470: forward -isystem flags to configure scripts Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. bazel-contrib/rules_foreign_cc#1462 bumps bazel_lib to 3.2.0; follow up to 3.2.2 to get path-mapping compatibility with Bazel 9.
### What does this PR do? Switch `rules_foreign_cc` from `single_version_override` on 0.15.1 to a `git_override` on `main`. Implies to bump `bazel_lib` to 3.2+ (see bazel-contrib/rules_foreign_cc#1462). ### Motivation Pick up three upstream fixes: 1. bazel-contrib/rules_foreign_cc#1451 (allows to **drop our corresponding patch**), 2. bazel-contrib/rules_foreign_cc#1465 (avoids build action **over-committing**), 3. bazel-contrib/rules_foreign_cc#1470. ### Additional Notes Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
### What does this PR do? Switch `rules_foreign_cc` from `single_version_override` on 0.15.1 to a `git_override` on `main`. Implies to bump `bazel_lib` to 3.2+ (see bazel-contrib/rules_foreign_cc#1462). ### Motivation Pick up three upstream fixes: 1. bazel-contrib/rules_foreign_cc#1451 (allows to **drop our corresponding patch**), 2. bazel-contrib/rules_foreign_cc#1465 (avoids build action **over-committing**), 3. bazel-contrib/rules_foreign_cc#1470. ### Additional Notes Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
This does a few things: