Skip to content

Bump rules_foreign_cc for 3 improvements#47799

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/rules-foreign-cc-git-override
Mar 13, 2026
Merged

Bump rules_foreign_cc for 3 improvements#47799
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/rules-foreign-cc-git-override

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Mar 12, 2026 •
edited
Loading

What does this PR do?

Switch rules_foreign_cc from single_version_override on 0.15.1 to a git_override on main.

Implies to bump bazel_lib to 3.2+ (see bazel-contrib/rules_foreign_cc#1462).

Motivation

Pick up three upstream fixes:

  1. allow out_data_dirs to be referenced through output groups bazel-contrib/rules_foreign_cc#1451 (allows to drop our corresponding patch),
  2. feat: integrate bazel resource_sets into the build actions bazel-contrib/rules_foreign_cc#1465 (avoids build action over-committing),
  3. Add -isystem to make / pkgconfig flags bazel-contrib/rules_foreign_cc#1470.

Additional Notes

Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open.

@rdesgroppes
Bump rules_foreign_cc to main, drop merged patch, bump bazel_lib
a9da998 
Switch rules_foreign_cc from single_version_override on 0.15.1 to a
git_override on main (e4068330) to pick up three upstream fixes:

- bazel-contrib/rules_foreign_cc#1451: out_data_dirs in output groups
  (our patch 0001 verbatim — drop it)
- bazel-contrib/rules_foreign_cc#1465: resource_set integration, which
  lets Bazel's scheduler respect CPU/RAM budgets and avoids build action
  overcommitting
- bazel-contrib/rules_foreign_cc#1470: forward -isystem flags to
  configure scripts

Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as
bazel-contrib/rules_foreign_cc#1452 is still open.

bazel-contrib/rules_foreign_cc#1462 bumps bazel_lib to 3.2.0; follow
up to 3.2.2 to get path-mapping compatibility with Bazel 9.
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 12, 2026
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Mar 12, 2026
@github-actions github-actions bot added the medium review PR review might take time label Mar 12, 2026
@rdesgroppes rdesgroppes changed the title Bump rules_foreign_cc to main, drop merged patch, bump bazel_lib Bump rules_foreign_cc for 3 improvements Mar 12, 2026
@rdesgroppes rdesgroppes marked this pull request as ready for review March 12, 2026 22:17
@rdesgroppes rdesgroppes requested a review from a team as a code owner March 12, 2026 22:17
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Mar 12, 2026

Files inventory check summary

File checks results against ancestor f9ca8e01:

Results for datadog-agent_7.78.0~devel.git.556.a9da998.pipeline.102274620-1_amd64.deb:

Detected file changes:

1 Changed files:
  • opt/datadog-agent/embedded/bin/kinit:
    • Size changed: +11.73% (34.11 KiB -> 38.11 KiB)

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Mar 12, 2026 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1f393202-fd13-4c48-bd9b-39f60d87bd5c

Baseline: 7a8ac38
Comparison: badbc1c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.68 [-0.34, +5.70] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.68 [-0.34, +5.70] 1 Logs
➖ quality_gate_logs % cpu utilization +1.30 [-0.31, +2.91] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput +0.74 [+0.61, +0.87] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.59 [+0.35, +0.82] 1 Logs bounds checks dashboard
➖ ddot_metrics memory utilization +0.41 [+0.24, +0.58] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.36 [+0.30, +0.42] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.33 [+0.19, +0.48] 1 Logs
➖ ddot_logs memory utilization +0.18 [+0.11, +0.24] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.09 [+0.02, +0.16] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.09 [-0.44, +0.61] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.06 [-0.33, +0.44] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.05 [+0.01, +0.09] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.18, +0.21] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.43, +0.44] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.10] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.18, +0.17] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.10 [-0.32, +0.12] 1 Logs
➖ file_tree memory utilization -0.12 [-0.17, -0.07] 1 Logs
➖ ddot_metrics_sum_delta memory utilization -0.15 [-0.31, +0.01] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.22 [-0.38, -0.06] 1 Logs
➖ quality_gate_idle memory utilization -0.29 [-0.33, -0.24] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -0.50 [-0.58, -0.43] 1 Logs
➖ otlp_ingest_logs memory utilization -0.53 [-0.64, -0.43] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ docker_containers_cpu simple_check_run 10/10 720 ≥ 26
✅ docker_containers_memory memory_usage 10/10 272.20MiB ≤ 370MiB
✅ docker_containers_memory simple_check_run 10/10 729 ≥ 26
✅ file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
✅ file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
✅ file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
✅ file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
✅ file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
✅ file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
✅ quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 174.36MiB ≤ 175MiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 488.25MiB ≤ 550MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 202.42MiB ≤ 220MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 346.02 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 407.23MiB ≤ 475MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Mar 12, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f9ca8e0
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 +11.99 KiB (0.00% increase) 747.015 → 747.026 → 750.720
✅ agent_deb_amd64_fips +11.99 KiB (0.00% increase) 705.327 → 705.339 → 711.230
✅ agent_heroku_amd64 +7.99 KiB (0.00% increase) 311.763 → 311.770 → 320.580
✅ agent_rpm_amd64 +11.99 KiB (0.00% increase) 746.998 → 747.010 → 750.690
✅ agent_rpm_amd64_fips +11.99 KiB (0.00% increase) 705.311 → 705.322 → 711.210
✅ agent_rpm_arm64 +12.02 KiB (0.00% increase) 724.899 → 724.911 → 732.890
✅ agent_rpm_arm64_fips +12.02 KiB (0.00% increase) 686.178 → 686.190 → 694.440
✅ agent_suse_amd64 +11.99 KiB (0.00% increase) 746.998 → 747.010 → 750.690
✅ agent_suse_amd64_fips +11.99 KiB (0.00% increase) 705.311 → 705.322 → 711.210
✅ agent_suse_arm64 +12.02 KiB (0.00% increase) 724.899 → 724.911 → 732.890
✅ agent_suse_arm64_fips +12.02 KiB (0.00% increase) 686.178 → 686.190 → 694.440
✅ docker_agent_amd64 +11.99 KiB (0.00% increase) 807.328 → 807.340 → 813.040
✅ docker_agent_arm64 +12.03 KiB (0.00% increase) 810.042 → 810.054 → 819.570
✅ docker_agent_jmx_amd64 +11.99 KiB (0.00% increase) 998.243 → 998.255 → 1003.920
✅ docker_agent_jmx_arm64 +12.03 KiB (0.00% increase) 989.736 → 989.748 → 999.170
16 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_msi 609.859 MiB
✅ docker_cluster_agent_amd64 203.681 MiB
✅ docker_cluster_agent_arm64 218.164 MiB
✅ docker_cws_instrumentation_amd64 7.142 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 38.639 MiB
✅ docker_dogstatsd_arm64 36.939 MiB
✅ dogstatsd_deb_amd64 29.859 MiB
✅ dogstatsd_deb_arm64 28.016 MiB
✅ dogstatsd_rpm_amd64 29.859 MiB
✅ dogstatsd_suse_amd64 29.859 MiB
✅ iot_agent_deb_amd64 43.076 MiB
✅ iot_agent_deb_arm64 40.138 MiB
✅ iot_agent_deb_armhf 40.878 MiB
✅ iot_agent_rpm_amd64 43.076 MiB
✅ iot_agent_suse_amd64 43.076 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 -32.82 KiB (0.02% reduction) 174.486 → 174.454 → 177.700
✅ agent_deb_amd64_fips +15.28 KiB (0.01% increase) 165.390 → 165.405 → 172.230
✅ agent_heroku_amd64 +8.27 KiB (0.01% increase) 75.170 → 75.178 → 79.970
✅ agent_msi +20.0 KiB (0.01% increase) 138.016 → 138.035 → 146.220
✅ agent_rpm_amd64 neutral 176.450 MiB → 180.780
✅ agent_rpm_amd64_fips -6.91 KiB (0.00% reduction) 168.077 → 168.071 → 173.370
✅ agent_rpm_arm64 -22.8 KiB (0.01% reduction) 159.368 → 159.346 → 161.610
✅ agent_rpm_arm64_fips +13.2 KiB (0.01% increase) 151.373 → 151.386 → 155.910
✅ agent_suse_amd64 neutral 176.450 MiB → 180.780
✅ agent_suse_amd64_fips -6.91 KiB (0.00% reduction) 168.077 → 168.071 → 173.370
✅ agent_suse_arm64 -22.8 KiB (0.01% reduction) 159.368 → 159.346 → 161.610
✅ agent_suse_arm64_fips +13.2 KiB (0.01% increase) 151.373 → 151.386 → 155.910
✅ docker_agent_amd64 +17.26 KiB (0.01% increase) 267.154 → 267.171 → 271.240
✅ docker_agent_arm64 -2.85 KiB (0.00% reduction) 254.469 → 254.467 → 259.800
✅ docker_agent_jmx_amd64 neutral 335.814 MiB → 339.870
✅ docker_agent_jmx_arm64 +16.44 KiB (0.01% increase) 319.096 → 319.112 → 324.390
✅ docker_cluster_agent_amd64 neutral 71.287 MiB → 72.920
✅ docker_cluster_agent_arm64 neutral 66.924 MiB → 68.220
✅ docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 14.951 MiB → 15.820
✅ docker_dogstatsd_arm64 neutral 14.288 MiB → 14.830
✅ dogstatsd_deb_amd64 neutral 7.889 MiB → 8.790
✅ dogstatsd_deb_arm64 neutral 6.774 MiB → 7.710
✅ dogstatsd_rpm_amd64 neutral 7.900 MiB → 8.800
✅ dogstatsd_suse_amd64 neutral 7.900 MiB → 8.800
✅ iot_agent_deb_amd64 neutral 11.356 MiB → 12.040
✅ iot_agent_deb_arm64 neutral 9.669 MiB → 10.450
✅ iot_agent_deb_armhf neutral 9.898 MiB → 10.620
✅ iot_agent_rpm_amd64 neutral 11.373 MiB → 12.060
✅ iot_agent_suse_amd64 neutral 11.373 MiB → 12.060

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit badbc1c into main Mar 13, 2026
300 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/rules-foreign-cc-git-override branch March 13, 2026 11:14
@github-actions github-actions bot added this to the 7.78.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alopezz alopezz alopezz approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Milestone

7.78.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rdesgroppes @alopezz