allow out_data_dirs to be referenced through output groups#1451
Merged
cerisier merged 1 commit intobazel-contrib:mainfrom Jan 12, 2026
Merged
allow out_data_dirs to be referenced through output groups#1451cerisier merged 1 commit intobazel-contrib:mainfrom
cerisier merged 1 commit intobazel-contrib:mainfrom
Conversation
dd-mergequeue bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Dec 18, 2025
### What does this PR do? Build krb5 with bazel ### Motivation Migration of our 3rd party dependencies to bazel https://datadoghq.atlassian.net/browse/ABLD-274 ### Describe how you validated your changes Local build for linux x86_64 ### Additional Notes This PR also contains a patch that can be seen as a PR upstream: bazel-contrib/rules_foreign_cc#1451 This will drop all the executables that we currently install: ``` bin/compile_et bin/gss-client bin/k5srvutil bin/kadmin bin/kdestroy bin/kinit bin/klist bin/kpasswd bin/krb5-config bin/ksu bin/kswitch bin/ktutil bin/kvno bin/sclient bin/sim_client bin/uuclient ``` and ``` sbin/gss-server sbin/kadmin.local sbin/kadmind sbin/kdb5_util sbin/kprop sbin/kpropd sbin/kproplog sbin/krb5-send-pr sbin/krb5kdc sbin/sim_server sbin/sserver sbin/uuserver ``` Co-authored-by: hugo.beauzee <hugo.beauzee@datadoghq.com>
mwdd146980
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Dec 23, 2025
### What does this PR do? Build krb5 with bazel ### Motivation Migration of our 3rd party dependencies to bazel https://datadoghq.atlassian.net/browse/ABLD-274 ### Describe how you validated your changes Local build for linux x86_64 ### Additional Notes This PR also contains a patch that can be seen as a PR upstream: bazel-contrib/rules_foreign_cc#1451 This will drop all the executables that we currently install: ``` bin/compile_et bin/gss-client bin/k5srvutil bin/kadmin bin/kdestroy bin/kinit bin/klist bin/kpasswd bin/krb5-config bin/ksu bin/kswitch bin/ktutil bin/kvno bin/sclient bin/sim_client bin/uuclient ``` and ``` sbin/gss-server sbin/kadmin.local sbin/kadmind sbin/kdb5_util sbin/kprop sbin/kpropd sbin/kproplog sbin/krb5-send-pr sbin/krb5kdc sbin/sim_server sbin/sserver sbin/uuserver ``` Co-authored-by: hugo.beauzee <hugo.beauzee@datadoghq.com>
Contributor
|
@cerisier Would you consider merging it? |
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 12, 2026
Switch rules_foreign_cc from single_version_override on 0.15.1 to a git_override on main (e4068330) to pick up three upstream fixes: - bazel-contrib/rules_foreign_cc#1451: out_data_dirs in output groups (our patch 0001 verbatim — drop it) - bazel-contrib/rules_foreign_cc#1465: resource_set integration, which lets Bazel's scheduler respect CPU/RAM budgets and avoids build action overcommitting - bazel-contrib/rules_foreign_cc#1470: forward -isystem flags to configure scripts Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. bazel-contrib/rules_foreign_cc#1462 bumps bazel_lib to 3.2.0; follow up to 3.2.2 to get path-mapping compatibility with Bazel 9. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 12, 2026
Switch rules_foreign_cc from single_version_override on 0.15.1 to a git_override on main (e4068330) to pick up three upstream fixes: - bazel-contrib/rules_foreign_cc#1451: out_data_dirs in output groups (our patch 0001 verbatim — drop it) - bazel-contrib/rules_foreign_cc#1465: resource_set integration, which lets Bazel's scheduler respect CPU/RAM budgets and avoids build action overcommitting - bazel-contrib/rules_foreign_cc#1470: forward -isystem flags to configure scripts Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. bazel-contrib/rules_foreign_cc#1462 bumps bazel_lib to 3.2.0; follow up to 3.2.2 to get path-mapping compatibility with Bazel 9.
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 13, 2026
### What does this PR do? Switch `rules_foreign_cc` from `single_version_override` on 0.15.1 to a `git_override` on `main`. Implies to bump `bazel_lib` to 3.2+ (see bazel-contrib/rules_foreign_cc#1462). ### Motivation Pick up three upstream fixes: 1. bazel-contrib/rules_foreign_cc#1451 (allows to **drop our corresponding patch**), 2. bazel-contrib/rules_foreign_cc#1465 (avoids build action **over-committing**), 3. bazel-contrib/rules_foreign_cc#1470. ### Additional Notes Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
theop-dd
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 16, 2026
### What does this PR do? Switch `rules_foreign_cc` from `single_version_override` on 0.15.1 to a `git_override` on `main`. Implies to bump `bazel_lib` to 3.2+ (see bazel-contrib/rules_foreign_cc#1462). ### Motivation Pick up three upstream fixes: 1. bazel-contrib/rules_foreign_cc#1451 (allows to **drop our corresponding patch**), 2. bazel-contrib/rules_foreign_cc#1465 (avoids build action **over-committing**), 3. bazel-contrib/rules_foreign_cc#1470. ### Additional Notes Patch 0002 (LD_LIBRARY_PATH propagation) is kept locally as bazel-contrib/rules_foreign_cc#1452 is still open. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows one to easily reference the content of folders listed in
out_data_dirsthrough an output group, instead of relying ongen_dir&genrule