Skip to content

Rename actual/expected test files to input/output#7578

Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom
CodingItWrong:finish-actual-expected-test-file-rename
Mar 15, 2018
Merged

Rename actual/expected test files to input/output#7578
nicolo-ribaudo merged 1 commit intobabel:masterfrom
CodingItWrong:finish-actual-expected-test-file-rename

Conversation

@CodingItWrong
Copy link
Copy Markdown
Contributor

@CodingItWrong CodingItWrong commented Mar 15, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Several test files appear to have been missed in the update of test file naming from actual/expected.js to input/output.js. As a result, they were silently not being run. I've confirmed that they were not running, updated the names, then confirmed that they are running now.

These files appear to have been missed in the update of test file naming from actual/expected.js to input/output.js. As a result, they were silently not being run. I've confirmed that they were not running, updated the names, then confirmed that they are running now.
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Mar 15, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7267/

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Thank you!

@nicolo-ribaudo nicolo-ribaudo merged commit b8d1d22 into babel:master Mar 15, 2018
@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Mar 15, 2018
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
These files appear to have been missed in the update of test file naming from actual/expected.js to input/output.js. As a result, they were silently not being run. I've confirmed that they were not running, updated the names, then confirmed that they are running now.
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Mar 18, 2018
* master: (131 commits)
  v7.0.0-beta.42
  Use strict namespace behavior for mjs files. (babel#7545)
  Remove outdated spec deviation note [skip ci] (babel#7571)
  Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580)
  Rename actual/expected test files to input/output (babel#7578)
  Use helper-module-import inside entry plugin too
  Use helper-module-imports instead of custom import (babel#7457)
  Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575)
  Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188)
  Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390)
  Fix incorrect value of _cache in _wrapNativeSuper (babel#7570)
  [transform-classes] Fix typo in _wrapNativeSuper helper
  [typeof-symbol] Guard against undefined built-in globals
  update to beta.41 (babel#7568)
  v7.0.0-beta.41
  Fix import of type ConfigItem (babel#7561)
  Run node 9 on circleci and remove from travis (babel#7560)
  docs: [skip ci] fix proposal link text
  update preset-env after build-data (babel#7543)
  Re-add TEST_ONLY and use Jest's -t for TEST_GREP. (babel#7556)
  ...
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Mar 18, 2018
…ature/pipe-await

* 'master' of https://github.com/valtech-nyc/babel: (131 commits)
  v7.0.0-beta.42
  Use strict namespace behavior for mjs files. (babel#7545)
  Remove outdated spec deviation note [skip ci] (babel#7571)
  Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580)
  Rename actual/expected test files to input/output (babel#7578)
  Use helper-module-import inside entry plugin too
  Use helper-module-imports instead of custom import (babel#7457)
  Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575)
  Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188)
  Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390)
  Fix incorrect value of _cache in _wrapNativeSuper (babel#7570)
  [transform-classes] Fix typo in _wrapNativeSuper helper
  [typeof-symbol] Guard against undefined built-in globals
  update to beta.41 (babel#7568)
  v7.0.0-beta.41
  Fix import of type ConfigItem (babel#7561)
  Run node 9 on circleci and remove from travis (babel#7560)
  docs: [skip ci] fix proposal link text
  update preset-env after build-data (babel#7543)
  Re-add TEST_ONLY and use Jest's -t for TEST_GREP. (babel#7556)
  ...
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Mar 21, 2018
* master: (140 commits)
  Update to beta.42 (babel#7609)
  Disable flow on transformClass, fix preset-env errors (babel#7605)
  Logical Assignment: ensure computed key isn't recomputed (babel#7604)
  Remove obsolete max-len eslint rule and reformat some stuff to fit (babel#7602)
  Centralize Babel's own compilation config to make it easier to follow. (babel#7599)
  Run prettier to format all JSON.
  Tweak es2015-related plugin order in preset-env (babel#7586)
  Refactored quirky inheritance in babel-plugin-transform-classes (babel#7444)
  Add RegExp support to include/exclude preset-env options (babel#7242)
  v7.0.0-beta.42
  Use strict namespace behavior for mjs files. (babel#7545)
  Remove outdated spec deviation note [skip ci] (babel#7571)
  Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580)
  Rename actual/expected test files to input/output (babel#7578)
  Use helper-module-import inside entry plugin too
  Use helper-module-imports instead of custom import (babel#7457)
  Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575)
  Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188)
  Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390)
  Fix incorrect value of _cache in _wrapNativeSuper (babel#7570)
  ...
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants