Centralize Babel's own compilation config to make it easier to follow.#7599
Merged
loganfsmyth merged 1 commit intobabel:masterfrom Mar 20, 2018
Merged
Centralize Babel's own compilation config to make it easier to follow.#7599loganfsmyth merged 1 commit intobabel:masterfrom
loganfsmyth merged 1 commit intobabel:masterfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7325/ |
98dc21e to
20b7d0d
Compare
hzoo
reviewed
Mar 20, 2018
.babelrc.js
Outdated
| "@babel/proposal-export-namespace-from", | ||
| "@babel/proposal-numeric-separator", | ||
| ["@babel/proposal-object-rest-spread", { useBuiltIns: true }], | ||
| ].concat(convertESM ? ["@babel/transform-modules-commonjs"] : []), |
Member
There was a problem hiding this comment.
not that different but convertESM ? ["@babel/transform-modules-commonjs"] : [] and .filter(Boolean) works too
Member
Author
There was a problem hiding this comment.
Great call, I'll do that instead.
hzoo
approved these changes
Mar 20, 2018
20b7d0d to
01e3d55
Compare
01e3d55 to
11a1bc2
Compare
mAAdhaTTah
added a commit
to valtech-nyc/babel
that referenced
this pull request
Mar 21, 2018
* master: (140 commits) Update to beta.42 (babel#7609) Disable flow on transformClass, fix preset-env errors (babel#7605) Logical Assignment: ensure computed key isn't recomputed (babel#7604) Remove obsolete max-len eslint rule and reformat some stuff to fit (babel#7602) Centralize Babel's own compilation config to make it easier to follow. (babel#7599) Run prettier to format all JSON. Tweak es2015-related plugin order in preset-env (babel#7586) Refactored quirky inheritance in babel-plugin-transform-classes (babel#7444) Add RegExp support to include/exclude preset-env options (babel#7242) v7.0.0-beta.42 Use strict namespace behavior for mjs files. (babel#7545) Remove outdated spec deviation note [skip ci] (babel#7571) Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580) Rename actual/expected test files to input/output (babel#7578) Use helper-module-import inside entry plugin too Use helper-module-imports instead of custom import (babel#7457) Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575) Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188) Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390) Fix incorrect value of _cache in _wrapNativeSuper (babel#7570) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think this makes things easier?