Re-add TEST_ONLY and use Jest's -t for TEST_GREP.#7556
Merged
loganfsmyth merged 1 commit intobabel:masterfrom Mar 12, 2018
Merged
Re-add TEST_ONLY and use Jest's -t for TEST_GREP.#7556loganfsmyth merged 1 commit intobabel:masterfrom
loganfsmyth merged 1 commit intobabel:masterfrom
Conversation
Member
|
But this also means TEST_ONLY needs to match the complete package name and cannot be a simple subset. |
existentialism
approved these changes
Mar 12, 2018
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7219/ |
Member
Author
|
Oh I missed that TEST_ONLY could actually match a part of the package name, woops! |
7848b7c to
f3143ce
Compare
This was referenced Mar 15, 2018
Closed
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
mAAdhaTTah
added a commit
to valtech-nyc/babel
that referenced
this pull request
Mar 18, 2018
* master: (131 commits) v7.0.0-beta.42 Use strict namespace behavior for mjs files. (babel#7545) Remove outdated spec deviation note [skip ci] (babel#7571) Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580) Rename actual/expected test files to input/output (babel#7578) Use helper-module-import inside entry plugin too Use helper-module-imports instead of custom import (babel#7457) Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575) Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188) Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390) Fix incorrect value of _cache in _wrapNativeSuper (babel#7570) [transform-classes] Fix typo in _wrapNativeSuper helper [typeof-symbol] Guard against undefined built-in globals update to beta.41 (babel#7568) v7.0.0-beta.41 Fix import of type ConfigItem (babel#7561) Run node 9 on circleci and remove from travis (babel#7560) docs: [skip ci] fix proposal link text update preset-env after build-data (babel#7543) Re-add TEST_ONLY and use Jest's -t for TEST_GREP. (babel#7556) ...
mAAdhaTTah
added a commit
to valtech-nyc/babel
that referenced
this pull request
Mar 18, 2018
…ature/pipe-await * 'master' of https://github.com/valtech-nyc/babel: (131 commits) v7.0.0-beta.42 Use strict namespace behavior for mjs files. (babel#7545) Remove outdated spec deviation note [skip ci] (babel#7571) Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580) Rename actual/expected test files to input/output (babel#7578) Use helper-module-import inside entry plugin too Use helper-module-imports instead of custom import (babel#7457) Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575) Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188) Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390) Fix incorrect value of _cache in _wrapNativeSuper (babel#7570) [transform-classes] Fix typo in _wrapNativeSuper helper [typeof-symbol] Guard against undefined built-in globals update to beta.41 (babel#7568) v7.0.0-beta.41 Fix import of type ConfigItem (babel#7561) Run node 9 on circleci and remove from travis (babel#7560) docs: [skip ci] fix proposal link text update preset-env after build-data (babel#7543) Re-add TEST_ONLY and use Jest's -t for TEST_GREP. (babel#7556) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7455 we lost TEST_ONLY, but some of the docs still reference it.
I also changed TEST_GREP to use Jest's
-t, which I think is more consistent with the behavior before #7455.I actually successfully did something with Bash. Amazing.