Use jest by danez · Pull Request #7455 · babel/babel

danez · 2018-02-28T15:27:30Z

Q	A
Fixed Issues?	#6179 #6442
Patch: Bug Fix?	n
Major: Breaking Change?	n
Minor: New Feature?	n
Tests Added + Pass?	Yes
Documentation PR
Any Dependency Changes?
License	MIT

Rebase of #6179. Seems i removed my fork repo. :)

All tests work, babel-register is skipped for now. But I have an idea how to fix it, by mocking pirates and just checking what babel-register is doing, pirates is covered with tests anyway so we don't have to test it.

SimenB · 2018-02-28T15:42:14Z

test/testSetupFile.js

@@ -0,0 +1,2 @@
+/* eslint-env jasmine */
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;


you can use jest.setTimeout

SimenB · 2018-02-28T15:43:20Z

.babelrc.js

@@ -32,11 +43,4 @@ if (process.env.BABEL_ENV === "cov") {
  config.plugins.push("babel-plugin-istanbul");


should this still be here? Jest adds it itself (and you removed it from package.json)

SimenB · 2018-02-28T15:52:51Z

.babelrc.js

@@ -40,7 +40,6 @@ const config = {

 if (process.env.BABEL_ENV === "cov") {
  config.auxiliaryCommentBefore = "istanbul ignore next";


jest also does this

:) even better

https://github.com/facebook/jest/blob/a88d3c553d94b220f9dae47f64983d9d7b3baed8/packages/jest-runtime/src/script_transformer.js#L153-L169

hzoo · 2018-02-28T15:54:40Z

@danez maybe you didn't see #6442? we were going to merge that but not sure the relation @rogeliog

oh nvm I see you referenced it

danez · 2018-02-28T15:57:13Z

I think there is no need to use the mocha runner, because just using the default jest runner works fine.

hzoo · 2018-02-28T16:02:15Z

.travis.yml

+  - '9'
  - '8'
  - '6'
-  - '4'


This seems unrelated? We are we dropping node 4 testing already?

Can use node environment and keep 4? (like in babel-upgrade)

If it's because of jest, it still works on node 4 if you use the node environment - https://github.com/babel/babel-upgrade works fine with it.

ok cool, I revert then.

hzoo · 2018-02-28T16:03:08Z

packages/babel-code-frame/src/index.js

  if (!deprecationWarningShown) {
    deprecationWarningShown = true;

-    const deprecationError = new Error(


I'm ok with just not doing the warning anymore and making this a breaking change. We can just fix this automatically with https://github.com/babel/babel-upgrade

We can do this in a separate PR.

rogeliog · 2018-02-28T16:44:49Z

I agree with @danez! The Mocha runner is a good option when the complexity of the codebase makes it hard to fully migrate to Jest or as an intermediate step. Seem that I'll close it in favor of this, I can reopen it if needed.

hzoo · 2018-02-28T16:51:51Z

Ok well if this works I'm for it too 👍 , thanks for your efforts @rogeliog, sorry we didn't actually end up merging the PR 😅

babel-bot · 2018-02-28T17:52:29Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7039/

existentialism

Let's get this landed!

danez · 2018-03-01T18:34:00Z

Ok I hope the coverage is now correct. I had to readd the babel-plugin-istanbul as some of our tests test the code in lib and not src. Wherever possible I changed to test src directly, but the fixture runner which runs stuff in separate envs couldn't be changed easily.

Okay I reverted this change and instead we test the transpiled code in lib, so that we have no change here atm, because I remembered that we did that on purpose at least for babylon as we want to test the compiled files/bundles. We can still change that later. babel-jest is now only used to compile the test files itself.

SimenB · 2018-03-01T18:56:01Z

Anything jest can do to help/improve, or is it just a quirk (feature) of babel's tests?

danez · 2018-03-01T19:06:09Z

I think that we in the past implemented some features that jest might already do, like running each test in a spearate vm (https://github.com/babel/babel/blob/master/packages/babel-helper-transform-fixture-test-runner/src/index.js#L87).
The other thing is that we bundle some packages with rollup/webpack and we want to test the bundle rather than the source in this cases to ensure that the bundles work.
We might be able to get rid of some of this now, but I want to make this PR as small as possible.

Andarist · 2018-03-01T22:02:02Z

Super cool 👍I was wondering - it should be possible to migrate to builtin snapshots instead of custom setup in the future, right? This would allow easier test updates

hzoo · 2018-03-01T22:04:04Z

I actually like the individual files lol compared to reading the snapshot output now lol

Andarist · 2018-03-01T22:07:40Z

What's the difference though? A single snapshot format? Maybe it's possible to integrate with snapshot system to output whatever we want in whatever directory we want, just have it backed by jest's built-in system for this. expected files are a form of snapshots anyway

hzoo · 2018-03-01T22:10:32Z

Oh ok if you can change the format then that's cool. I just mean https://github.com/babel/babel-upgrade/blob/51534a4bd3f742d284d42e231ae36e71c83bc93d/__tests__/__snapshots__/packageData.test.js.snap#L5-L12 vs the actual js

Andarist · 2018-03-01T22:12:58Z

Actually I have no idea if its possible to change the whole format, it's for sure possible to write custom serializer, but not sure if a snapshot file can be an actual js file, not assigned to exports etc (jest snapshots are actually requireable). Worth investigating in the future

danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 28, 2018

SimenB reviewed Feb 28, 2018

View reviewed changes

hzoo reviewed Feb 28, 2018

View reviewed changes

danez force-pushed the pr-6179 branch from fab9bb7 to 55fec9f Compare February 28, 2018 16:18

rogeliog mentioned this pull request Feb 28, 2018

[Proposal] Use Jest with Mocha Runner #6442

Closed

5 tasks

danez force-pushed the pr-6179 branch from 080855e to 1d06186 Compare March 1, 2018 06:31

existentialism approved these changes Mar 1, 2018

View reviewed changes

Migrate to jest

e417be4

danez force-pushed the pr-6179 branch from 33ff20d to e417be4 Compare March 1, 2018 19:13

hzoo approved these changes Mar 1, 2018

View reviewed changes

Andarist approved these changes Mar 1, 2018

View reviewed changes

danez merged commit 3e95830 into master Mar 3, 2018

danez deleted the pr-6179 branch March 3, 2018 09:58

danez mentioned this pull request Mar 3, 2018

Migrate chai and assert usages to jest expect #7476

Closed

danez mentioned this pull request Mar 3, 2018

Figure out why core and cli dropped in coverage #7478

Closed

loganfsmyth mentioned this pull request Mar 12, 2018

Re-add TEST_ONLY and use Jest's -t for TEST_GREP. #7556

Merged

aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018

Migrate to jest (babel#7455)

dbe8868

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019

		@@ -0,0 +1,2 @@
		/* eslint-env jasmine */
		jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;

		@@ -32,11 +43,4 @@ if (process.env.BABEL_ENV === "cov") {
		config.plugins.push("babel-plugin-istanbul");

		@@ -40,7 +40,6 @@ const config = {

		if (process.env.BABEL_ENV === "cov") {
		config.auxiliaryCommentBefore = "istanbul ignore next";

Uh oh!

Conversation

danez commented Feb 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzoo commented Feb 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danez commented Feb 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rogeliog commented Feb 28, 2018

Uh oh!

hzoo commented Feb 28, 2018

Uh oh!

babel-bot commented Feb 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

existentialism left a comment

Choose a reason for hiding this comment

Uh oh!

danez commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danez commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andarist commented Mar 1, 2018

Uh oh!

hzoo commented Mar 1, 2018

Uh oh!

Andarist commented Mar 1, 2018

Uh oh!

hzoo commented Mar 1, 2018

Uh oh!

Andarist commented Mar 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

danez commented Feb 28, 2018 •

edited

Loading

hzoo commented Feb 28, 2018 •

edited

Loading

danez commented Feb 28, 2018 •

edited

Loading

babel-bot commented Feb 28, 2018 •

edited

Loading

danez commented Mar 1, 2018 •

edited

Loading

SimenB commented Mar 1, 2018 •

edited

Loading

danez commented Mar 1, 2018 •

edited

Loading