Raise limit on code size before compacting#4965
Conversation
Current coverage is 89.23% (diff: 50.00%)@@ master #4965 diff @@
==========================================
Files 204 204
Lines 10494 10494
Methods 1154 1154
Messages 0 0
Branches 2761 2761
==========================================
Hits 9364 9364
Misses 1130 1130
Partials 0 0
|
|
We should remember to update the docs here, too.
|
* master: make installing runtime/transform-runtime clearer [skip ci] (babel#4991) Add example to es2015-unicode-regex [skip ci] (babel#4983) v6.20.3 Calculate the correct arity for async functions with destructuring - fixes babel#4977 (babel#4978) v6.20.2 fix object spread (babel#4976) fix clean lib update readme [skip ci] v6.20.1 Fix nested object spread (babel#4974) v6.20.0 v6.20.0 changelog [skip ci] (babel#4971) Raise limit on code size before compacting (babel#4965) Use regenerator-transform to implement babel-plugin-transform-regenerator (babel#4881) Add getBindingIdentifierPaths/getOuterBindingIdentifierPaths (babel#4876) Hoist generateDeclaredUidIdentifier helper function (babel#4934)
* master: (89 commits) fix sizing [skip ci] typo [skip ci] changelog for v6.20.1 to v6.20.3 [skip ci] mention repl/link [skip ci] add semver label [skip ci] Fix links in CONTRIBUTING.md [skip ci] (babel#4989) make installing runtime/transform-runtime clearer [skip ci] (babel#4991) Add example to es2015-unicode-regex [skip ci] (babel#4983) v6.20.3 Calculate the correct arity for async functions with destructuring - fixes babel#4977 (babel#4978) v6.20.2 fix object spread (babel#4976) fix clean lib update readme [skip ci] v6.20.1 Fix nested object spread (babel#4974) v6.20.0 v6.20.0 changelog [skip ci] (babel#4971) Raise limit on code size before compacting (babel#4965) Use regenerator-transform to implement babel-plugin-transform-regenerator (babel#4881) ...
|
this change resulted in some issues in one of my builds. with this limit being raised to 500000 my babel process gets stuck on 100% and never exits. i was able to track it and the last babel line of code that gets frozen is this https://github.com/babel/babel/blob/master/packages/babel-generator/src/buffer.js#L43 after that it leaves babel and goes into lodash code (https://github.com/lodash/lodash/blob/master/trimEnd.js#L32) reverting this change solves the issue. Is there any way to configure it or can it be reverted? |
|
@DmitriiAbramov Opened a separate issue (#5081) to discuss this further so this comment doesn't get lost in the shuffle. |
I know @loganfsmyth has mentioned 500kb a few times, figured we can remove it altogether after some time has passed.