Hoist generateDeclaredUidIdentifier helper function#4934
Merged
hzoo merged 1 commit intobabel:masterfrom Dec 8, 2016
Merged
Conversation
1fc7341 to
e287a8b
Compare
e287a8b to
484f92d
Compare
Current coverage is 89.22% (diff: 68.00%)
|
Member
|
We should work on our tests coverage at some point haha 👍 |
Jessidhia
pushed a commit
to Jessidhia/babel
that referenced
this pull request
Dec 12, 2016
* master: make installing runtime/transform-runtime clearer [skip ci] (babel#4991) Add example to es2015-unicode-regex [skip ci] (babel#4983) v6.20.3 Calculate the correct arity for async functions with destructuring - fixes babel#4977 (babel#4978) v6.20.2 fix object spread (babel#4976) fix clean lib update readme [skip ci] v6.20.1 Fix nested object spread (babel#4974) v6.20.0 v6.20.0 changelog [skip ci] (babel#4971) Raise limit on code size before compacting (babel#4965) Use regenerator-transform to implement babel-plugin-transform-regenerator (babel#4881) Add getBindingIdentifierPaths/getOuterBindingIdentifierPaths (babel#4876) Hoist generateDeclaredUidIdentifier helper function (babel#4934)
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist the helper function, to avoid allocating it every time
Scope#generateDeclaredUidIdentifieris called.