Skip to content

Add getBindingIdentifierPaths/getOuterBindingIdentifierPaths#4876

Merged
hzoo merged 2 commits intobabel:masterfrom
boopathi:get-binding-id-path-0
Dec 8, 2016
Merged

Add getBindingIdentifierPaths/getOuterBindingIdentifierPaths#4876
hzoo merged 2 commits intobabel:masterfrom
boopathi:get-binding-id-path-0

Conversation

@boopathi
Copy link
Copy Markdown
Member

@boopathi boopathi commented Nov 21, 2016

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets
License MIT
Doc PR
Dependency Changes

The path API - getBindingIdentifers() returns a list of Nodes instead of Paths.

New APIs:

  • path.getBindingIdentifierPaths() - same as getBindingIdentifiers() - but returns Paths instead of Nodes
  • path.getOuterBindingIdentifierPaths() - same as getOuterBindingIdentifiers() - but returns Paths instead of Nodes

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 21, 2016

Current coverage is 89.19% (diff: 77.14%)

Merging #4876 into master will decrease coverage by 0.16%

@@             master      #4876   diff @@
==========================================
  Files           196        204      +8   
  Lines         14020      10529   -3491   
  Methods        1460       1155    -305   
  Messages          0          0           
  Branches       3262       2774    -488   
==========================================
- Hits          12528       9391   -3137   
+ Misses         1492       1138    -354   
  Partials          0          0           

Powered by Codecov. Last update 3a27f49...7f6c036

@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Dec 2, 2016
@boopathi
Copy link
Copy Markdown
Member Author

boopathi commented Dec 8, 2016

Updated.

@hzoo hzoo changed the title Add getBindingIdentifierPaths Add getBindingIdentifierPaths/getOuterBindingIdentifierPaths Dec 8, 2016
@hzoo hzoo merged commit 73ff13f into babel:master Dec 8, 2016
@boopathi boopathi deleted the get-binding-id-path-0 branch December 8, 2016 21:51
Jessidhia pushed a commit to Jessidhia/babel that referenced this pull request Dec 12, 2016
* master:
  make installing runtime/transform-runtime clearer [skip ci] (babel#4991)
  Add example to es2015-unicode-regex [skip ci] (babel#4983)
  v6.20.3
  Calculate the correct arity for async functions with destructuring - fixes babel#4977 (babel#4978)
  v6.20.2
  fix object spread (babel#4976)
  fix clean lib
  update readme [skip ci]
  v6.20.1
  Fix nested object spread (babel#4974)
  v6.20.0
  v6.20.0 changelog [skip ci] (babel#4971)
  Raise limit on code size before compacting (babel#4965)
  Use regenerator-transform to implement babel-plugin-transform-regenerator (babel#4881)
  Add getBindingIdentifierPaths/getOuterBindingIdentifierPaths (babel#4876)
  Hoist generateDeclaredUidIdentifier helper function (babel#4934)
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants