Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2927 +/- ##
==========================================
- Coverage 78.36% 78.13% -0.24%
==========================================
Files 689 689
Lines 121144 121581 +437
Branches 16973 16982 +9
==========================================
+ Hits 94935 94996 +61
- Misses 25314 25700 +386
+ Partials 895 885 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
samuel40791765
left a comment
There was a problem hiding this comment.
Nice work! Could you take the changes to pass_util.cc in this PR I closed and add the changes here as well? Seems like the changes are very related to what we're trying to achieve here, thanks!
Contributor
|
Valgrind reports use of uninitialized data: |
samuel40791765
previously approved these changes
Jan 5, 2026
Contributor
|
The PR has several conflicts, largely due to formatting changes. |
justsmth
reviewed
Mar 6, 2026
justsmth
approved these changes
Mar 9, 2026
samuel40791765
approved these changes
Mar 10, 2026
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
### Description of changes: This PR addresses the remaining comments from PRs aws#2877 and aws#2898. I also took the liberty to clean up `tool-openssl` to make our code easier to read. ### Testing: Unit tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: Samuel Chiang <sachiang@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR addresses the remaining comments from PRs #2877 and #2898. I also took the liberty to clean up
tool-opensslto make our code easier to read.Testing:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.