clean up pass_util namespace and _WIN32 macro#2928
Closed
samuel40791765 wants to merge 1 commit intoaws:mainfrom
Closed
clean up pass_util namespace and _WIN32 macro#2928samuel40791765 wants to merge 1 commit intoaws:mainfrom
samuel40791765 wants to merge 1 commit intoaws:mainfrom
Conversation
3d058ac to
e3bc231
Compare
Merged
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
+ Coverage 78.17% 78.41% +0.24%
==========================================
Files 690 690
Lines 118663 118738 +75
Branches 16680 16684 +4
==========================================
+ Hits 92759 93104 +345
+ Misses 25017 24742 -275
- Partials 887 892 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pass_util.ccwas calling it's own namespace as a separate file, when it could be consolidated into one. I'm skeptical if a namespace is even needed though, it seems a bit redundant, but I won't tweak this part for now.OPENSSL_WINDOWSmacro instead of_WIN32in tool-openssl.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.