Conversation
209088d to
ed636be
Compare
cdf5497 to
1ae912b
Compare
1ae912b to
7e88cca
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
+ Coverage 78.22% 78.34% +0.11%
==========================================
Files 683 685 +2
Lines 117491 118348 +857
Branches 16510 16643 +133
==========================================
+ Hits 91909 92716 +807
- Misses 24694 24740 +46
- Partials 888 892 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 75a5db5.
justsmth
previously approved these changes
Dec 11, 2025
justsmth
previously approved these changes
Dec 11, 2025
skmcgrail
reviewed
Dec 11, 2025
justsmth
previously approved these changes
Dec 12, 2025
justsmth
approved these changes
Dec 12, 2025
samuel40791765
approved these changes
Dec 12, 2025
nhatnghiho
added a commit
to nhatnghiho/aws-lc
that referenced
this pull request
Jan 2, 2026
Merged
nhatnghiho
added a commit
to nhatnghiho/aws-lc
that referenced
this pull request
Jan 13, 2026
justsmth
pushed a commit
that referenced
this pull request
Mar 10, 2026
### Description of changes: This PR addresses the remaining comments from PRs #2877 and #2898. I also took the liberty to clean up `tool-openssl` to make our code easier to read. ### Testing: Unit tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: Samuel Chiang <sachiang@amazon.com>
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
### Description of changes: This PR addresses the remaining comments from PRs aws#2877 and aws#2898. I also took the liberty to clean up `tool-openssl` to make our code easier to read. ### Testing: Unit tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: Samuel Chiang <sachiang@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Modify a few of our CLI commands to match OpenSSL's behavior:
ecparam:-genkeyis provided despite-noout. Previously, writing is suppressed with-nooutx509: Set serial number when signingpkeyutl:-pkeyoptrsa_pss_saltlen:-1as a valid pkeyopt valuereq: Suppress key write if-keyis provided and no-keyoutis specifiedTesting:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.