Skip to content

Remove deprecated tests/command.py module and really deprecate test runner for v8.0#17883

Merged
pllim merged 4 commits into
astropy:mainfrom
pllim:rm-tests-command-v8
Nov 4, 2025
Merged

Remove deprecated tests/command.py module and really deprecate test runner for v8.0#17883
pllim merged 4 commits into
astropy:mainfrom
pllim:rm-tests-command-v8

Conversation

@pllim

@pllim pllim commented Mar 13, 2025

Copy link
Copy Markdown
Member

Description

This pull request is to

This PR should stay in draft until main is v8.0.dev.

After merge

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added the API change PRs and issues that change an existing API, possibly requiring a deprecation period label Mar 13, 2025
@pllim pllim added this to the v8.0.0 milestone Mar 13, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim changed the title Remove deprecated tests/command.py module for v8.0 Remove deprecated tests/command.py module and really deprecate test runner for v8.0 Jul 4, 2025
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Aug 11, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@pllim pllim force-pushed the rm-tests-command-v8 branch from 5264b76 to 6d1513d Compare August 12, 2025 17:53
@pllim pllim removed the Close? Tell stale bot that this issue/PR is stale label Aug 12, 2025
@pllim pllim force-pushed the rm-tests-command-v8 branch from 6d1513d to d8341c7 Compare November 3, 2025 22:58
@pllim

This comment was marked as outdated.

@pllim

This comment was marked as resolved.

@pllim pllim force-pushed the rm-tests-command-v8 branch from bc3688a to 56f8168 Compare November 3, 2025 23:24
@pllim pllim force-pushed the rm-tests-command-v8 branch from 56f8168 to d622c92 Compare November 3, 2025 23:25
@pllim pllim added Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection labels Nov 3, 2025
@pllim pllim marked this pull request as ready for review November 4, 2025 01:25
@pllim pllim requested a review from bsipocz November 4, 2025 01:27

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks!

Comment thread docs/changes/tests/17883.api.rst Outdated
@pllim pllim merged commit 9b0b0f8 into astropy:main Nov 4, 2025
50 checks passed
@pllim pllim deleted the rm-tests-command-v8 branch November 4, 2025 21:37
@pllim

pllim commented Nov 4, 2025

Copy link
Copy Markdown
Member Author

Let the deprecation begin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate astropy test runner in core and downstream

2 participants