Skip to content

MNT: Deprecate tests/command.py#15204

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:deprecate-test-command
Aug 20, 2023
Merged

MNT: Deprecate tests/command.py#15204
pllim merged 1 commit into
astropy:mainfrom
pllim:deprecate-test-command

Conversation

@pllim

@pllim pllim commented Aug 19, 2023

Copy link
Copy Markdown
Member

Description

Deprecate tests/command.py because astropy-helpers had reached EOL a long time ago.

Fixes #12686

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v6.0 milestone Aug 19, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

This comment was marked as resolved.

@pllim pllim force-pushed the deprecate-test-command branch from 4ac20b5 to 4d234cb Compare August 19, 2023 01:21
because astropy-helpers had reached EOL a long time ago.

Also skip it in testing.
@pllim pllim force-pushed the deprecate-test-command branch from 4d234cb to f090bb7 Compare August 19, 2023 02:03
@pllim pllim marked this pull request as ready for review August 19, 2023 02:28
@pllim pllim requested review from astrofrog and saimn August 19, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MNT: Deprecate astropy/tests/command.py

2 participants