Skip to content

TST: test against CPython 3.13 final#17139

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/cp313
Oct 8, 2024
Merged

TST: test against CPython 3.13 final#17139
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/cp313

Conversation

@neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Oct 8, 2024 •
edited by pllim
Loading

Description

Close #16858 and close #16595
Following #16595, this should be backported

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review October 8, 2024 16:30
@pllim pllim modified the milestones: v7.0.0, v6.1.5 Oct 8, 2024
pllim
pllim reviewed Oct 8, 2024
View reviewed changes
.github/workflows/ci_cron_weekly.yml Outdated
toxenv: py313-test-devdeps

- name: Python 3.12 on macOS (x86_64) with all optional dependencies
- name: Python 3.13 on macOS (x86_64) with all optional dependencies
Copy link
Member

@pllim pllim Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.13 with all deps so early in release might not fly...

Copy link
Contributor Author

@neutrinoceros neutrinoceros Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup. Just trying out my luck here. Will revert if (when ?) it comes down crashing into flames.

Copy link
Contributor Author

@neutrinoceros neutrinoceros Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pyarrow is missing wheels on PyPI and fails to build on macOS so I'll revert that part tommorrow and will open a new reminder issue then.

xref
apache/arrow#43519

Copy link
Contributor Author

@neutrinoceros neutrinoceros Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind I just did it in #17140

@pllim pllim added the Extra CI Run cron CI as part of PR label Oct 8, 2024
pllim
pllim reviewed Oct 8, 2024
View reviewed changes
.github/workflows/ci_cron_weekly.yml
os: macos-13
python: '3.12'
python: '3.13'
toxenv: py312-test-alldeps
Copy link
Member

@pllim pllim Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering why it didn't fail. 😆

Suggested change
toxenv: py312-test-alldeps
toxenv: py313-test-alldeps

Copy link
Contributor Author

@neutrinoceros neutrinoceros Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, too good to be true I guess. Thanks for catching it ! 😄

@neutrinoceros neutrinoceros marked this pull request as draft October 8, 2024 17:53
@neutrinoceros neutrinoceros mentioned this pull request Oct 8, 2024
Closed
@neutrinoceros neutrinoceros marked this pull request as ready for review October 8, 2024 17:57
pllim
pllim approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in. The exotic arch failures are unrelated. I think those are from plethora of recent refactoring in units. I will open new issue for that one.

@pllim pllim merged commit eb98949 into astropy:main Oct 8, 2024
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@neutrinoceros neutrinoceros deleted the tst/cp313 branch October 8, 2024 19:40
@pllim
Copy link
Member

pllim commented Oct 8, 2024

@neutrinoceros are you interested in manual backport? If not, I can look into that tomorrow. Thanks!

@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Oct 8, 2024

I can do it in the morning. Thanks for the ping

neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Oct 9, 2024
@pllim @neutrinoceros
Merge pull request astropy#17139 from neutrinoceros/tst/cp313
929e5c4 
TST: test against CPython 3.13 final
@neutrinoceros neutrinoceros mentioned this pull request Oct 9, 2024
Merged
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Oct 9, 2024

done in #17142

pllim added a commit that referenced this pull request Oct 9, 2024
@pllim
Merge pull request #17142 from neutrinoceros/bp/17139
4df027e 
Backport PR #17139 on branch v6.1.x (TST: test against CPython 3.13 final)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Extra CI Run cron CI as part of PR no-changelog-entry-needed Python 3.13 testing

Projects

None yet

Milestone

v6.1.5

Development

Successfully merging this pull request may close these issues.

TST: Update test matrix when Python 3.13 stable is out CPython 3.13 support (tracker issue)

2 participants

@neutrinoceros @pllim