Skip to content

Backport PR #17139 on branch v6.1.x (TST: test against CPython 3.13 final)#17142

Merged
pllim merged 1 commit intoastropy:v6.1.xfrom
neutrinoceros:bp/17139
Oct 9, 2024
Merged

Backport PR #17139 on branch v6.1.x (TST: test against CPython 3.13 final)#17142
pllim merged 1 commit intoastropy:v6.1.xfrom
neutrinoceros:bp/17139

Conversation

@neutrinoceros
Copy link
Contributor

manual backport for #17139

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v6.1.5 milestone Oct 9, 2024
@pllim pllim closed this Oct 9, 2024
@pllim pllim reopened this Oct 9, 2024
@pllim pllim added the Extra CI Run cron CI as part of PR label Oct 9, 2024
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are unrelated.

@pllim pllim merged commit 4df027e into astropy:v6.1.x Oct 9, 2024
@pllim
Copy link
Member

pllim commented Oct 9, 2024

Thanks!

@neutrinoceros neutrinoceros deleted the bp/17139 branch October 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants