DEP: drop support for Python 3.10 by neutrinoceros · Pull Request #16903 · astropy/astropy

neutrinoceros · 2024-08-29T09:55:58Z

Description

Fixes Request: drop python 3.10 support now (since it will not be needed for 7.0) #16900.

I initially just wanted to measure the diff of doing this but ended up doing all (?) the work needed, so might as well open a ~~draft~~ PR.

This would enable:

FAQ

Q: When is this going to be released?
A: End of 2024. Please see https://github.com/astropy/astropy/wiki/Release-Calendar

Q: Why so soon? Python 3.10 EOL is not till Oct 2026.
A: This is due to https://github.com/astropy/astropy-APEs/blob/main/APE18.rst that follows https://scientific-python.org/specs/spec-0000/ that recommends, "Support for Python versions be dropped 3 years after their initial release."

Subpackage approvals

After merge

Repo admin needs to update branch protection rules for main.

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2024-08-29T09:56:26Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions · 2024-08-29T09:56:28Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

mhvk

This looks all good to me! Approving though second set of eyes on the CI changes would be very helpful.

neutrinoceros · 2024-08-29T13:08:23Z

I also revived changes from #16680 (re: #16680 (comment))

mhvk · 2024-08-29T13:16:13Z

One more thing: I just checked and you ended up removing all actual usage of typing_extensions - maybe a reason to drop it as a dependency? Though since it is in the special typing category, no strong incentive to do so.

neutrinoceros · 2024-08-29T13:37:34Z

Good point, let's clean that up while we're at it. I'll keep the typing extra target though, we never know when we'll need it again and it doesn't hurt if it's empty for some time.

neutrinoceros · 2024-08-29T13:47:51Z

might as well undraft this now

pllim · 2024-09-05T14:13:29Z

Oh no, another conflict. Can you please rebase again? Thanks!

and sync oldestdeps pins. Also remove other mentions of very old Python versions. Remove ignoring warning in pytest that no longer needs to be ignored. No longer need to specific numpy 2.0.0rc in pins now that stable is out. DOC: Clarify change log a bit more.

that is not needed since Python 3.4. Co-authored-by: Marten van Kerkwijk <mhvk@astro.utoronto.ca>

…e oldest supported numpy

neutrinoceros · 2024-09-05T14:20:40Z

rebased ! (I think it's time we merge this)

pllim · 2024-09-05T14:29:55Z

Re: oldestdeps + alldeps

Looks like it came from #12522 (comment) by @saimn . It was a while ago when we do not have so many "optional" dependencies and that PR was to simplify jobs, so this combo was not necessarily to fix some specific problem we had per se. So we can definitely rethink it. See #16950

eerovaher · 2024-09-05T16:39:03Z

docs/changes/16903.other.rst

@@ -0,0 +1 @@
+Updated minimum supported Python version to 3.11. As a result, minimum required versions for ``ipython``, ``packaging``, ``pyarrow``, PyYAML, and ``scipy`` were updated as well to be compatible, while ``tomli`` and ``typing_extensions`` are no longer needed.


As a user I would like optional and mandatory dependencies to be distinguished (we don't need to go into any details beyond that).

@eerovaher , any suggested wordings? I think everything I added are "optional".

tomli and typing_extensions were only needed for development, so they should not have been mentioned in the change log at all.

I plan to follow up on this. Thanks !

pllim · 2024-09-05T21:20:38Z

aarch64 failure unrelated and the daily cron with remote data timeout also unrelated. I am going to modify the change log for Eero the best I can and then merge this before poor Clément have to rebase again.

[ci skip]

pllim · 2024-09-05T21:34:06Z

I updated main branch protection rules. Please let me know if anything is amiss after a rebase of any open PR. Thanks, all!

neutrinoceros · 2024-09-06T06:41:30Z

Thanks @pllim for all your help !

DOC: simplify changelog entry for #16903

github-actions bot added testing Docs io.fits time units Release modeling cosmology utils installation utils.iers labels Aug 29, 2024

neutrinoceros force-pushed the dep/drop_cp310 branch from 8d71ea2 to f25d6a9 Compare August 29, 2024 10:47

neutrinoceros mentioned this pull request Aug 29, 2024

Request: drop python 3.10 support now (since it will not be needed for 7.0) #16900

Closed

mhvk added this to the v7.0.0 milestone Aug 29, 2024

neutrinoceros mentioned this pull request Aug 29, 2024

Use Exceptions with Notes #16879

Open

mhvk approved these changes Aug 29, 2024

View reviewed changes

neutrinoceros force-pushed the dep/drop_cp310 branch from 7246a53 to c21d784 Compare August 29, 2024 13:37

neutrinoceros marked this pull request as ready for review August 29, 2024 13:47

neutrinoceros requested review from a team, saimn and taldcroft as code owners August 29, 2024 13:47

neutrinoceros requested a review from nstarman August 29, 2024 13:47

pllim added the zzz 💤 Python3.10 archived: Python 3.10 is no longer supported label Aug 29, 2024

mhvk mentioned this pull request Sep 5, 2024

Implement mechanism for more flexible unit parsing #16892

Merged

1 task

neutrinoceros and others added 7 commits September 5, 2024 16:20

DEP: drop support for Python 3.10

ff4efcd

TST: switch Python 3.11 jobs to 3.12

e23db1e

CLN: cleanup unused conditions in compatibility test code

6c09203

MNT: Refactor old code in io.ascii

4e459a1

that is not needed since Python 3.4. Co-authored-by: Marten van Kerkwijk <mhvk@astro.utoronto.ca>

DEP: set minimal requirement for optional dep dask[array] to match th…

09cc1a2

…e oldest supported numpy

restore .pre-commit-config.yaml

4e5f0ae

neutrinoceros force-pushed the dep/drop_cp310 branch from 1172050 to 4e5f0ae Compare September 5, 2024 14:20

pllim mentioned this pull request Sep 5, 2024

TST: Decouple alldeps from oldestdeps #16950

Closed

eerovaher reviewed Sep 5, 2024

View reviewed changes

Changelog to separate required and optional deps

c69c9ab

[ci skip]

pllim merged commit e581eab into astropy:main Sep 5, 2024

neutrinoceros deleted the dep/drop_cp310 branch September 6, 2024 06:41

This was referenced Sep 6, 2024

DEP: add missing lower bounds to dependencies from oldestdeps-alldeps #16960

Merged

TST: have oldestdeps trully pin every direct dependency using uv's --resolution=lowest-direct #16963

Merged

neutrinoceros added a commit to neutrinoceros/astropy that referenced this pull request Sep 8, 2024

DOC: simplify changelog entry for astropy#16903

ae79d10

neutrinoceros mentioned this pull request Sep 8, 2024

DOC: simplify changelog entry for #16903 #16970

Merged

1 task

pllim added a commit that referenced this pull request Sep 9, 2024

Merge pull request #16970 from neutrinoceros/doc/update_16903_changelog

7329eeb

DOC: simplify changelog entry for #16903

pllim mentioned this pull request Sep 9, 2024

Does this package Python minversion follow astropy? astropy/astropy-iers-data#27

Closed

larrybradley mentioned this pull request Oct 14, 2024

Drop support for Python 3.10 astropy/photutils#1930

Merged

larrybradley mentioned this pull request Nov 23, 2024

Drop Support for Python 3.10 astropy/photutils#1958

Merged

kkrutkowski pushed a commit to kkrutkowski/astropy that referenced this pull request Apr 13, 2025

DOC: simplify changelog entry for astropy#16903

d8d4ab1

nstarman mentioned this pull request Jun 30, 2025

build(deps): typing-extensions as a dependency #18360

Open

1 task

		@@ -0,0 +1 @@
		Updated minimum supported Python version to 3.11. As a result, minimum required versions for ``ipython``, ``packaging``, ``pyarrow``, PyYAML, and ``scipy`` were updated as well to be compatible, while ``tomli`` and ``typing_extensions`` are no longer needed.

Uh oh!

Conversation

neutrinoceros commented Aug 29, 2024 • edited by pllim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

FAQ

Subpackage approvals

After merge

Uh oh!

github-actions bot commented Aug 29, 2024

Uh oh!

github-actions bot commented Aug 29, 2024

Uh oh!

mhvk left a comment

Choose a reason for hiding this comment

Uh oh!

neutrinoceros commented Aug 29, 2024

Uh oh!

mhvk commented Aug 29, 2024

Uh oh!

neutrinoceros commented Aug 29, 2024

Uh oh!

neutrinoceros commented Aug 29, 2024

Uh oh!

pllim commented Sep 5, 2024

Uh oh!

neutrinoceros commented Sep 5, 2024

Uh oh!

pllim commented Sep 5, 2024

Uh oh!

eerovaher Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

pllim Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

eerovaher Sep 6, 2024

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Sep 6, 2024

Choose a reason for hiding this comment

Uh oh!

pllim commented Sep 5, 2024

Uh oh!

pllim commented Sep 5, 2024

Uh oh!

neutrinoceros commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

neutrinoceros commented Aug 29, 2024 •

edited by pllim

Loading