Skip to content

DOC: simplify changelog entry for #16903#16970

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:doc/update_16903_changelog
Sep 9, 2024
Merged

DOC: simplify changelog entry for #16903#16970
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:doc/update_16903_changelog

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

Follow up to #16903 as requested by @eerovaher (#16903 (comment))

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mhvk mhvk added this to the v7.0.0 milestone Sep 9, 2024
@mhvk mhvk added Docs skip-changelog-checks Tells bot to skip changlog checks labels Sep 9, 2024
@eerovaher
Copy link
Copy Markdown
Member

Maybe we should have a look at all the new change log entries and not just this one?

@mhvk
Copy link
Copy Markdown
Contributor

mhvk commented Sep 9, 2024

Maybe we should have a look at all the new change log entries and not just this one?

That seems like a separate project... And not sure that is worth the effort - in principle, someone has reviewed the messages already, and it is not like many people will really do more than scan them...

@pllim pllim merged commit 7329eeb into astropy:main Sep 9, 2024
@pllim
Copy link
Copy Markdown
Member

pllim commented Sep 9, 2024

Thanks!

@neutrinoceros neutrinoceros deleted the doc/update_16903_changelog branch September 9, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs skip-changelog-checks Tells bot to skip changlog checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants