Skip to content

TST: switch Python 3.11 jobs to 3.12#16680

Closed
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:tst/cp312
Closed

TST: switch Python 3.11 jobs to 3.12#16680
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:tst/cp312

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

Python 3.12 should be old enough by now that we can count on a widespread support from the rest of the ecosystem, let's try switching regular CI (not just most bleeding-edge jobs) to it.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 5, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 5, 2024

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review July 5, 2024 13:28
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Ah, I did not anticipate that this would be another PR whose merge would impose a rebase for all other PRs.

@pllim
Copy link
Copy Markdown
Member

pllim commented Jul 5, 2024

I say we wait until we bump Python minversion. This is usually only done when we do that. Can we close this without merge? Thanks for your understanding!

@pllim pllim added this to the v7.0.0 milestone Jul 5, 2024
@pllim pllim added the Close? Tell stale bot that this issue/PR is stale label Jul 5, 2024
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Sure, no worries.

@pllim
Copy link
Copy Markdown
Member

pllim commented Jul 5, 2024

Yes, due to branch protection rules, any time we rename the test job, other PRs are affected.

@pllim pllim closed this Jul 5, 2024
@neutrinoceros neutrinoceros deleted the tst/cp312 branch July 5, 2024 15:27
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

I'd just note that this wasn't done in #15603 so in a sense it's overdue. But maybe we can skip 3.12 and go straight to 3.13 next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Close? Tell stale bot that this issue/PR is stale testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants