Bump minimum Python to 3.10 by nstarman · Pull Request #15603 · astropy/astropy

nstarman · 2023-11-11T15:51:47Z

v6.1 will be py3.10+.

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

.github/workflows/ci_cron_weekly.yml

nstarman · 2023-11-11T17:36:24Z

I bumped SciPy to 1.6, but looking at PyPI, SciPy v1.7.2 is the minimum version officially supporting py3.10 (https://pypi.org/project/scipy/1.7.2/). I guess we need to bump to SciPy v1.7.2?

Edit: numpy 1.23+ means we actually need SciPy 1.8+

.circleci/config.yml

.ruff.toml

CONTRIBUTING.md

astropy/cosmology/funcs/comparison.py

astropy/coordinates/tests/test_frames_with_velocity.py

nstarman · 2023-11-25T20:07:14Z

Documentation link check is failing because Astropy v6.0 isn't out yet but the docs have a link referencing v6.0
Tests "Python 3.12 with dev version of key dependencies" are numpy issues and I think unrelated to this PR.
Image test failures are real because the images need to be regenerated.

@pllim, I don't think I have the permissions to address the last point.

eerovaher · 2023-12-05T17:04:45Z

If it is possible to update the minimum required numpy and scipy versions without having to update the reference images then it would be a good idea to open a separate pull request for that.

saimn · 2023-12-18T20:53:15Z

3.10 is supposed to be supported until April, so if we want to have the option to release a minor version before that (e.g. for Numpy 2.0 in February) this PR should wait.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

With manual fixes for ruff-identified non-autofixable issues. Co-authored-by: Clément Robert <cr52@protonmail.com> Signed-off-by: nstarman <nstarman@users.noreply.github.com>

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

.github/workflows/ci_cron_weekly.yml

pllim

I like the clean-up but I won't merge yet to give other maintainers a chance to review. Though if you don't hear back from anyone else, we should get this in sooner than later to give downstream a chance to test this via nightly wheel.

Please ping me next week if no one else approves.

Thanks!

pllim · 2024-02-27T19:49:14Z

p.s. Auto merge won't work because the branch protection rules need updating but I cannot do that until after merge. I can override the protection when we have enough approvals.

mhvk

Great, thanks! Good as is, but if you address the second comment, might as well do the first too.

mhvk · 2024-02-27T20:20:10Z

docs/development/workflow/git_edit_workflow_examples.rst

  distribution::

-    conda create --name apy-1761 python=3.9 # replace 3.9 with desired version
+    conda create --name apy-1761 python=3.10 # replace 3.10 with desired version


If there are any other changes requested, might as well change this to 3.12 so we don't have to repeat it for a while...

mhvk · 2024-02-27T20:20:47Z

docs/units/type_hints.rst


-.. doctest-skip::
-
   >>> T.Union[Quantity[u.m], None]


Do you want to change this one to Quantity[u.m] | None too?

eerovaher

I have just one small remark.

astropy/units/tests/test_quantity_annotations.py

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

eerovaher

The patch here looks good to me. The commit history is a bit messy, but that could be fixed by squashing.

nstarman · 2024-03-08T05:00:19Z

Please ping me next week if no one else approves.

@pllim.

pllim · 2024-03-08T19:26:03Z

Yup yup... 😬

pllim · 2024-03-08T21:56:54Z

Branch protection rules updated.

nstarman added this to the v6.1 milestone Nov 11, 2023

nstarman force-pushed the bump-py-310 branch from 7b54953 to e30e5b4 Compare November 11, 2023 15:53

nstarman added whatsnew-needed Extra CI Run cron CI as part of PR labels Nov 11, 2023

nstarman force-pushed the bump-py-310 branch 3 times, most recently from 3759be6 to bb72973 Compare November 11, 2023 16:46

nstarman commented Nov 11, 2023

View reviewed changes

.github/workflows/ci_cron_weekly.yml Outdated Show resolved Hide resolved

nstarman commented Nov 11, 2023

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

nstarman force-pushed the bump-py-310 branch 2 times, most recently from b25e30c to eb2ae71 Compare November 11, 2023 23:07

dhomeier changed the title ~~Bump Python to 3.10~~ Bump minimum Python to 3.10 Nov 13, 2023

nstarman force-pushed the bump-py-310 branch from eb2ae71 to b25a1f3 Compare November 16, 2023 17:11

eerovaher reviewed Nov 22, 2023

View reviewed changes

.ruff.toml Show resolved Hide resolved

eerovaher reviewed Nov 22, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

astropy/cosmology/funcs/comparison.py Outdated Show resolved Hide resolved

astropy/coordinates/tests/test_frames_with_velocity.py Outdated Show resolved Hide resolved

nstarman force-pushed the bump-py-310 branch 2 times, most recently from e475d9e to 3327c31 Compare November 25, 2023 19:50

neutrinoceros mentioned this pull request Dec 6, 2023

DEP: adjust requirements for extra dependency on typing-extensions #15686

Merged

1 task

nstarman mentioned this pull request Dec 10, 2023

Bump numpy & scipy #15706

Merged

1 task

nstarman force-pushed the bump-py-310 branch 3 times, most recently from 38334be to 186d842 Compare December 15, 2023 16:16

nstarman mentioned this pull request Dec 15, 2023

Cosmo as a dataclass #15484

Merged

1 task

nstarman force-pushed the bump-py-310 branch from 186d842 to 3763914 Compare December 21, 2023 01:44

nstarman force-pushed the bump-py-310 branch from 3763914 to 14d249f Compare January 10, 2024 23:59

nstarman mentioned this pull request Jan 11, 2024

Create units.typing module with QuantityLike #15860

Merged

nstarman and others added 5 commits February 27, 2024 14:05

bump python version

b14c2bc

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

run pre-commit for associated fixes.

f792894

With manual fixes for ruff-identified non-autofixable issues. Co-authored-by: Clément Robert <cr52@protonmail.com> Signed-off-by: nstarman <nstarman@users.noreply.github.com>

upgrade python-version-dependent code

f3fdb79

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

Bump ubuntu version in weekly tests

6b85018

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

tests: update figure tests

6fafe89

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

nstarman force-pushed the bump-py-310 branch from 9bd5734 to 6fafe89 Compare February 27, 2024 19:05

pllim reviewed Feb 27, 2024

View reviewed changes

.github/workflows/ci_cron_weekly.yml Show resolved Hide resolved

pllim approved these changes Feb 27, 2024

View reviewed changes

mhvk approved these changes Feb 27, 2024

View reviewed changes

eerovaher reviewed Feb 28, 2024

View reviewed changes

astropy/units/tests/test_quantity_annotations.py Outdated Show resolved Hide resolved

pllim mentioned this pull request Feb 28, 2024

TST: remove workarounds now that contourpy has unpinned nightlies #16122

Merged

1 task

address review comments

fe291df

Signed-off-by: nstarman <nstarman@users.noreply.github.com>

nstarman force-pushed the bump-py-310 branch from 488be1b to fe291df Compare February 28, 2024 20:20

nstarman requested a review from eerovaher February 28, 2024 20:26

eerovaher approved these changes Feb 29, 2024

View reviewed changes

pllim merged commit 06f9f34 into astropy:main Mar 8, 2024

This comment was marked as resolved.

Sign in to view

nstarman deleted the bump-py-310 branch March 8, 2024 22:44

This was referenced Mar 9, 2024

RFC: refactor copy argument sanitizing into a unified compat function #16170

Merged

RFC: refactor internal usage of copy=False to copy=COPY_IF_NEEDED #16166

Merged

CLN: cleanup unused bits now that Python 3.9 was dropped #16183

Merged

jmbhughes mentioned this pull request Mar 11, 2024

Update Python version to 3.10 punch-mission/punchbowl#104

Closed

This was referenced Mar 11, 2024

DOC: Test guide should be consistent with actual jobs we run #16185

Merged

astropy dropped Python 3.9, dependabot for Actions astropy/astropy-iers-data#22

Merged

emolter mentioned this pull request Mar 14, 2024

Restore compatability with Python 3.8 emolter/pylanetary#57

Closed

neutrinoceros mentioned this pull request Jul 5, 2024

TST: switch Python 3.11 jobs to 3.12 #16680

Closed

1 task

Uh oh!

Conversation

nstarman commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nstarman commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nstarman commented Nov 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eerovaher commented Dec 5, 2023

Uh oh!

saimn commented Dec 18, 2023

Uh oh!

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

pllim commented Feb 27, 2024

Uh oh!

mhvk left a comment

Choose a reason for hiding this comment

Uh oh!

mhvk Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

nstarman Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

mhvk Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

nstarman Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

eerovaher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eerovaher left a comment

Choose a reason for hiding this comment

Uh oh!

nstarman commented Mar 8, 2024

Uh oh!

pllim commented Mar 8, 2024

Uh oh!

This comment was marked as resolved.

pllim commented Mar 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nstarman commented Nov 11, 2023 •

edited

Loading

nstarman commented Nov 11, 2023 •

edited

Loading

nstarman commented Nov 25, 2023 •

edited

Loading