MNT: publish nightly cp313 wheels by neutrinoceros · Pull Request #16596 · astropy/astropy

neutrinoceros · 2024-06-20T15:44:58Z

Description

Partly address #16595.

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2024-06-20T15:45:25Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions · 2024-06-20T15:45:28Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

pllim · 2024-06-21T19:29:53Z

There is code change to support Python 3.13, so I wonder if change log is needed after all.

Also, as mentioned in #16595 , I wonder if it is still too early.

Even if not, maybe put in cron job instead of regular CI?

neutrinoceros · 2024-06-21T19:50:36Z

Daily or weekly, or both ?

neutrinoceros · 2024-06-21T19:56:28Z

Also, code change is only in a test, which as far as I understand isn't considered user facing ? Anyway that was my reasoning for not including a changelog.

pllim · 2024-06-21T20:00:57Z

.github/workflows/publish.yml

      env: |
-        CIBW_BEFORE_BUILD: '${{ ((github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'Build all wheels')) && 'pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple setuptools setuptools_scm cython numpy>=0.0.dev0 extension-helpers') || '' }}'
-        CIBW_BUILD_FRONTEND: '${{ ((github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'Build all wheels')) && 'pip; args: --no-build-isolation') || 'build' }}'
+        CIBW_ENVIRONMENT:        '${{ ((github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'Build all wheels')) && 'PIP_PRE=1 PIP_EXTRA_INDEX_URL=https://pypi.anaconda.org/scientific-python-nightly-wheels/simple') || '' }}'


I don't grok the changes here. Why is this needed for Python 3.13?

Building and testing on 3.13 currently requires using numpy nightlies, which is the motivation here. I enable PIP_PRE and Python pre-releases permanently when all wheels are required.

I also aligned the code so it's much easier to compare these long conditions.

I'll revert this when numpy and PyYaml have compatible wheels on PyPI

.github/workflows/publish.yml

astropy/time/tests/test_basic.py

pllim · 2024-06-21T20:05:07Z

For now, I think weekly is enough?

As for code change, I don't know. Depends on the meaning of the change in tested behavior, and also what else would end up changing before Python 3.13 stable is released. Too early to tell, maybe.

neutrinoceros · 2024-06-23T12:10:43Z

I've moved the most fundamental bit (testing weekly) over to #16600. This PR is now focused on nightly wheels and will wait for OpenAstronomy/github-actions-workflows#212

pllim · 2024-08-14T16:58:36Z

astropy/modeling/tests/test_parameters.py

+        # fallback to a no-op decorator
+        dec = lambda f: f
+
+    @dec


Can we just xfail with condition like https://docs.pytest.org/en/stable/how-to/skipping.html#condition-parameter instead of invoking lambda? Thanks.

We already have global xfail_strict setting.

I didn't remember this was allowed and couldn't load the documentation initially, thanks for reminding me. Done !

neutrinoceros · 2024-08-14T16:59:13Z

@pllim there you go. I also rebased #16659 on top of this one and reverted the xfail decorator there. This should now be ready for review !

pllim · 2024-08-14T19:21:48Z

.github/workflows/publish.yml

+        CIBW_TEST_SKIP: '*cp313*'
+      # TODO: remove CIBW_TEST_SKIP for cp313 after
+      # https://github.com/astropy/astropy/pull/16659 is merged


Do we still need this now that we have xfailed the modeling test?

whoops, no we don't. I'll remove this in #16659

pllim · 2024-08-14T19:29:06Z

We don't do nightly wheel from release branch. I don't see why we need to backport for now, especially if we're going to revert this and that later. We can worry about backport branch when we're ready to actually add Python 3.13 to regular CI.

pllim · 2024-08-14T19:32:10Z

Looking at CPython schedule: 3.13.0 final: Tuesday, 2024-10-01

Would take a while for upstream packages to do release with stable support for it. Not to mention conda.

And our own v7.0 feature freeze is tentatively 2024-10-25, so we might even be able to get away with not supporting Python 3.13 in the v6.1.x series.

pllim

Good enough for now. Thanks!

pllim · 2024-08-14T22:47:57Z

@bsipocz , if you don't see the Python 3.13 wheels tomorrow, please open new issue. Thanks!

astropy/.github/workflows/publish.yml

Lines 5 to 6 in ad86d7e

    
           # run every day at 4am UTC 
        
           - cron: '0 4 * * *'

neutrinoceros · 2024-08-15T06:13:10Z

They're up now https://pypi.anaconda.org/astropy/simple/astropy/
thanks @pllim for polishing this up !

…6596 WHL: revert temporary config for CPython 3.13 from #16596

github-actions bot added the testing label Jun 20, 2024

neutrinoceros marked this pull request as ready for review June 20, 2024 16:23

neutrinoceros requested a review from taldcroft as a code owner June 20, 2024 16:23

neutrinoceros mentioned this pull request Jun 20, 2024

CPython 3.13 support (tracker issue) #16595

Closed

21 tasks

neutrinoceros force-pushed the tst/cp313 branch from 77f9966 to 7b6cc26 Compare June 21, 2024 13:07

neutrinoceros marked this pull request as draft June 21, 2024 13:07

neutrinoceros marked this pull request as ready for review June 21, 2024 13:39

pllim added this to the v6.1.2 milestone Jun 21, 2024

pllim added Python 3.13 backport-v6.1.x labels Jun 21, 2024

pllim reviewed Jun 21, 2024

View reviewed changes

.github/workflows/publish.yml Outdated Show resolved Hide resolved

pllim reviewed Jun 21, 2024

View reviewed changes

astropy/time/tests/test_basic.py Outdated Show resolved Hide resolved

neutrinoceros marked this pull request as draft June 22, 2024 10:20

neutrinoceros force-pushed the tst/cp313 branch from 5b9ef10 to 8680134 Compare June 22, 2024 12:51

neutrinoceros marked this pull request as ready for review June 22, 2024 13:38

neutrinoceros force-pushed the tst/cp313 branch from 8680134 to 2933f54 Compare June 22, 2024 13:44

neutrinoceros marked this pull request as draft June 22, 2024 21:39

This was referenced Jun 23, 2024

FR: support dynamic CIBW_PRERELEASE_PYTHON and CIBW_FREETHREADED_SUPPORT in publish.yml OpenAstronomy/github-actions-workflows#212

Closed

TST: enable weekly testing against CPython 3.13 #16600

Merged

neutrinoceros force-pushed the tst/cp313 branch from 2933f54 to 1a98025 Compare June 23, 2024 12:08

neutrinoceros changed the title ~~TST: enable continuous testing against CPython 3.13 (failures are allowed)~~ MNT: publish nightly cp313 wheels Jun 23, 2024

neutrinoceros force-pushed the tst/cp313 branch from 1a98025 to 34c6436 Compare June 24, 2024 07:34

neutrinoceros force-pushed the tst/cp313 branch from 19454ba to 4ae12f4 Compare August 14, 2024 16:56

neutrinoceros mentioned this pull request Aug 14, 2024

TST: fix a test for compatibility with Python 3.13 #16659

Merged

1 task

pllim reviewed Aug 14, 2024

View reviewed changes

neutrinoceros marked this pull request as ready for review August 14, 2024 16:59

neutrinoceros requested a review from a team as a code owner August 14, 2024 16:59

neutrinoceros force-pushed the tst/cp313 branch from 4ae12f4 to 21595b9 Compare August 14, 2024 17:00

pllim reviewed Aug 14, 2024

View reviewed changes

pllim added the Build all wheels Run all the wheel builds rather than just a selection label Aug 14, 2024

pllim modified the milestones: v6.1.3, v7.0.0 Aug 14, 2024

pllim removed the backport-v6.1.x label Aug 14, 2024

pllim added the no-changelog-entry-needed label Aug 14, 2024

pllim approved these changes Aug 14, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

pllim added Build all wheels Run all the wheel builds rather than just a selection and removed Build all wheels Run all the wheel builds rather than just a selection labels Aug 14, 2024

neutrinoceros and others added 2 commits August 14, 2024 16:54

MNT: publish nightly cp313 wheels

584c5f0

Make diff more readable

bd80c8a

pllim force-pushed the tst/cp313 branch from 2245a47 to bd80c8a Compare August 14, 2024 20:54

pllim merged commit ad86d7e into astropy:main Aug 14, 2024

neutrinoceros deleted the tst/cp313 branch August 15, 2024 06:09

neutrinoceros added a commit to neutrinoceros/astropy that referenced this pull request Aug 19, 2024

WHL: revert temporary config for CPython 3.13 from astropy#16596

757dffe

neutrinoceros mentioned this pull request Aug 19, 2024

WHL: revert temporary config for CPython 3.13 from #16596 #16848

Merged

1 task

pllim added a commit that referenced this pull request Aug 19, 2024

Merge pull request #16848 from neutrinoceros/whl/cln/partial_revert_1…

b3eec79

…6596 WHL: revert temporary config for CPython 3.13 from #16596

neutrinoceros mentioned this pull request Aug 28, 2024

WHL: (v6.1.x) enable cp313 wheels #16895

Merged

1 task

Uh oh!

Conversation

neutrinoceros commented Jun 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Jun 20, 2024

Uh oh!

github-actions bot commented Jun 20, 2024

Uh oh!

pllim commented Jun 21, 2024

Uh oh!

neutrinoceros commented Jun 21, 2024

Uh oh!

neutrinoceros commented Jun 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pllim commented Jun 21, 2024

Uh oh!

neutrinoceros commented Jun 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neutrinoceros commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pllim commented Aug 14, 2024

Uh oh!

pllim commented Aug 14, 2024

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

pllim commented Aug 14, 2024

Uh oh!

neutrinoceros commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

neutrinoceros commented Jun 20, 2024 •

edited

Loading