Skip to content

WHL: revert temporary config for CPython 3.13 from #16596#16848

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:whl/cln/partial_revert_16596
Aug 19, 2024
Merged

WHL: revert temporary config for CPython 3.13 from #16596#16848
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:whl/cln/partial_revert_16596

Conversation

@neutrinoceros
Copy link
Contributor

Description

Following up on #16596 (comment) now that all core dependencies (pyerfa, numpy, pyyaml) have stable cp313 wheels on PyPI

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review August 19, 2024 06:24
@pllim pllim added this to the v7.0.0 milestone Aug 19, 2024
@pllim pllim added no-changelog-entry-needed Build all wheels Run all the wheel builds rather than just a selection labels Aug 19, 2024
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
Copy link
Member

pllim commented Aug 19, 2024

tsk tsk that label (#16853)... close/re-open and see

@pllim pllim closed this Aug 19, 2024
@pllim pllim reopened this Aug 19, 2024
@pllim pllim merged commit b3eec79 into astropy:main Aug 19, 2024
@neutrinoceros neutrinoceros deleted the whl/cln/partial_revert_16596 branch August 19, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build all wheels Run all the wheel builds rather than just a selection no-changelog-entry-needed Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants