Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Maybe something else needs to get ported over here from your original PR? The failure was not what I thought you are describing above. Please see https://github.com/astropy/astropy/actions/runs/9650759397/job/26617100567?pr=16600

Thanks!

Thanks, I missed that. Indeed it's an entirely new problem, so let me draft this until I can figure it out.

Got it. I was unknowingly including matplotlib in the mix when I removed -noscipy. I put it back in and now the failure is the one I expected. Since beta3 is due today, I'll rerun CI on this PR when that version is available on GHA to see if anything changes.

3.13.0b3 was just made available on GHA. Let's try this again.

Hm. Looks like weekly cron jobs don't trigger on re-opening. Let me rebase instead.

Whoops, I always forget that I also need to wait for the new version to be registered in https://github.com/actions/python-versions/blob/main/versions-manifest.json, so the run I just triggered still used beta 2
update: watch actions/python-versions#293

Looks like 20min between merge of the upstream PR and triggering here wasn't enough: we still got 3.13.0b2. I'll try again tomorrow.

Good ! I finally got beta 3 and now there's only one failure which looks like an upstream bug, I'll report this later today !

simplified this now that matplotlib/matplotlib#28293 was merged

I think there are no more blockers? Can use one more rebase though. Rebased.

Hmm. Let's try to backport this one. I can cherry-pick from the other PRs if needed on that backport PR.

I changed my mind about the backport. Updated milestone.