Skip to content

celestia-node chart as subchart of evm-stack#1403

Merged
quasystaty1 merged 1 commit intomainfrom
quasytaty1/celestia-node-dependency
Aug 28, 2024
Merged

celestia-node chart as subchart of evm-stack#1403
quasystaty1 merged 1 commit intomainfrom
quasytaty1/celestia-node-dependency

Conversation

@quasystaty1
Copy link
Copy Markdown
Contributor

@quasystaty1 quasystaty1 commented Aug 23, 2024

Summary

A change to dependency level in our charts, celestia-node will now be a direct sub chart of the evm-stack

Background

Changes to the way our chart works broke celestia-node chart deployment duo to dependency level issues, this PR aims to fix it.

Changes

  • moved celestia-node to be a dependency of evm-stack instead of evm-rollup
  • remove TOKEN_SERVER_URL and token server functionality
  • remove token-svc

Testing

Tested against a local k8 cluster, both with celestia-node enabled and disabled

Breaking changes

Non breaking but as default celestia auth is disabled, in case there is a need for a token with read/write access user with ssh access will have to fetch the key manually for conductor to operate properly.

Related Issues

closes #1362

@quasystaty1 quasystaty1 requested a review from a team as a code owner August 23, 2024 14:27
@quasystaty1 quasystaty1 requested a review from aajimal August 23, 2024 14:27
@github-actions github-actions bot added the cd label Aug 23, 2024
@quasystaty1 quasystaty1 requested a review from joroshiba August 23, 2024 14:53
@quasystaty1 quasystaty1 added the docker-build used to trigger docker builds on PRs label Aug 23, 2024
joroshiba
joroshiba approved these changes Aug 26, 2024
View reviewed changes
@quasystaty1 quasystaty1 force-pushed the quasytaty1/celestia-node-dependency branch 2 times, most recently from 4f5f106 to 8f5b129 Compare August 28, 2024 13:55
@quasystaty1 quasystaty1 force-pushed the quasytaty1/celestia-node-dependency branch from 8f5b129 to 3576c67 Compare August 28, 2024 13:56
@quasystaty1 quasystaty1 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit acf8c08 Aug 28, 2024
@quasystaty1 quasystaty1 deleted the quasytaty1/celestia-node-dependency branch August 28, 2024 14:17
steezeburger added a commit that referenced this pull request Aug 28, 2024
@steezeburger
Merge branch 'main' into feature/ibc-e2e-smoke-test
476db16 
* main:
  release(cli): new release for dusk-10 (#1418)
  celestia-node chart as subchart of evm-stack (#1403)
  chore(composer): Add instrumentation (#1326)
  fix(sequencer): update mempool benchmarks (ENG-733) (#1385)
steezeburger added a commit that referenced this pull request Aug 28, 2024
@steezeburger
Merge branch 'feature/ibc-e2e-smoke-test' into spike/noble-usdc
0ad8e2f 
* feature/ibc-e2e-smoke-test:
  release(cli): new release for dusk-10 (#1418)
  celestia-node chart as subchart of evm-stack (#1403)
  chore(composer): Add instrumentation (#1326)
  fix(sequencer): update mempool benchmarks (ENG-733) (#1385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joroshiba joroshiba joroshiba approved these changes

@aajimal aajimal Awaiting requested review from aajimal aajimal is a code owner automatically assigned from astriaorg/infra

Assignees

No one assigned

Labels

cd docker-build used to trigger docker builds on PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Celestia-node chart incompatible with evm-stack

2 participants

@quasystaty1 @joroshiba