Skip to content

chore(composer): Add instrumentation#1326

Merged
ethanoroshiba merged 7 commits intomainfrom
ENG-670/add_composer_instrumentation
Aug 28, 2024
Merged

chore(composer): Add instrumentation#1326
ethanoroshiba merged 7 commits intomainfrom
ENG-670/add_composer_instrumentation

Conversation

@ethanoroshiba
Copy link
Copy Markdown

@ethanoroshiba ethanoroshiba commented Jul 31, 2024

Summary

Added instrumentation to astria-composer

Background

Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.

Changes

  • Added instrumentation to all async function calls that are not long-lived.
  • Removed instrumentation from long-running functions.

Related Issues

Part of #1321

@github-actions github-actions bot added the composer pertaining to composer label Jul 31, 2024
@ethanoroshiba ethanoroshiba force-pushed the ENG-670/add_composer_instrumentation branch from ac481ff to a54bb2c Compare August 8, 2024 17:20
@ethanoroshiba ethanoroshiba marked this pull request as ready for review August 12, 2024 15:46
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner August 12, 2024 15:46
@ethanoroshiba ethanoroshiba added the observability observability, tracing, metrics label Aug 15, 2024
…1361)

## Summary
Shortened and streamlined geth and executor `run_until_stopped()`
functions to get rid of clippy exceptions and ensure events are emitted
within spans.

## Background
#1326 removed instrumentation on these `run_until_stopped()` functions,
which revealed a clippy warning for too many lines. Additionally, this
made it so that logging inside these functions would not be emitted
within any span.

## Changes
- Delegated many tasks to helper functions with instrumentation.
- Created new `utils` module to house a shared `report_exit_reason()`
function.
- Moved `ensure_chain_id_is_correct()` and `get_latest_nonce()` to
`init()` (previosuly `pre_run_checks()`)

## Testing
Passing all tests.


## Related Issues
Part of #1321

---------

Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
@ethanoroshiba ethanoroshiba added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit b311636 Aug 28, 2024
@ethanoroshiba ethanoroshiba deleted the ENG-670/add_composer_instrumentation branch August 28, 2024 13:36
steezeburger added a commit that referenced this pull request Aug 28, 2024
* main:
  release(cli): new release for dusk-10 (#1418)
  celestia-node chart as subchart of evm-stack (#1403)
  chore(composer): Add instrumentation (#1326)
  fix(sequencer): update mempool benchmarks (ENG-733) (#1385)
steezeburger added a commit that referenced this pull request Aug 28, 2024
* feature/ibc-e2e-smoke-test:
  release(cli): new release for dusk-10 (#1418)
  celestia-node chart as subchart of evm-stack (#1403)
  chore(composer): Add instrumentation (#1326)
  fix(sequencer): update mempool benchmarks (ENG-733) (#1385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

composer pertaining to composer observability observability, tracing, metrics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants