fix(sequencer): update mempool benchmarks (ENG-733)#1385
Merged
Conversation
joroshiba
approved these changes
Aug 26, 2024
steezeburger
added a commit
that referenced
this pull request
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent changes to the mempool broke the benchmarks. This PR fixes that.
Background
Specifically, the benchmarks tests were failing in two ways: the limit on number of parked txs per account was causing the addition of txs to fail, and the pending nonce was returning
Nonein the tests.This was all due to the current account nonce being provided as 0, but the txs started from nonce 1, meaning they weren't eligible for adding to the pending queue.
Changes
Testing
Ran the benchmark and observed the full suite passing.
Related Issues
Closes #1384.