[red-knot] Use type[Unknown] rather than Unknown as the fallback metaclass for invalid classes#14961
Merged
AlexWaygood merged 1 commit intomainfrom Dec 13, 2024
Merged
[red-knot] Use type[Unknown] rather than Unknown as the fallback metaclass for invalid classes#14961AlexWaygood merged 1 commit intomainfrom
type[Unknown] rather than Unknown as the fallback metaclass for invalid classes#14961AlexWaygood merged 1 commit intomainfrom
Conversation
…metaclass for invalid classes
carljm
approved these changes
Dec 13, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes things so that we now infer
type[Unknown]rather thanUnknownas the fallback metaclass for an invalid class (either one that has a cyclic definition, or one where the metaclasses of the bases conflict). This better reflects the invariant that a class's metaclass must always be an instance oftype. It follows the same principles established in #14942.Test Plan
Assertions in existing mdtests updated. No new mdtests added, since the existing ones are reasonably comprehensive.