Skip to content

[red-knot] Understand Annotated#14950

Merged
carljm merged 24 commits intoastral-sh:mainfrom
InSyncWithFoo:rk-annotated
Dec 13, 2024
Merged

[red-knot] Understand Annotated#14950
carljm merged 24 commits intoastral-sh:mainfrom
InSyncWithFoo:rk-annotated

Conversation

@InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented Dec 13, 2024

Summary

Resolves #14922.

Test Plan

Markdown tests.

@InSyncWithFoo InSyncWithFoo force-pushed the rk-annotated branch 6 times, most recently from 8f32540 to df74504 Compare December 13, 2024 03:18
@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Dec 13, 2024

Alright, I'm out of ideas for now. What am I missing?

carljm
carljm reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Sorry about the bad experience, our expression coverage and the way it manifests in hard-to-debug errors is a known pain point we want to improve.

@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Dec 13, 2024
AlexWaygood
AlexWaygood reviewed Dec 13, 2024
View reviewed changes
AlexWaygood
AlexWaygood reviewed Dec 13, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood reviewed Dec 13, 2024
View reviewed changes
InSyncWithFoo and others added 4 commits December 13, 2024 13:33
@InSyncWithFoo
Fix again
0ed607f
@InSyncWithFoo @AlexWaygood
Update crates/red_knot_python_semantic/src/types/diagnostic.rs
fbe0a4e 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@InSyncWithFoo @AlexWaygood
Apply suggestions from code review
7568b31 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@InSyncWithFoo
Rebase
f34c372
AlexWaygood
AlexWaygood reviewed Dec 13, 2024
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexWaygood AlexWaygood requested a review from carljm December 13, 2024 15:06
carljm
carljm approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

InSyncWithFoo and others added 4 commits December 13, 2024 16:26
carljm
carljm approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@carljm carljm merged commit aa1938f into astral-sh:main Dec 13, 2024
@InSyncWithFoo InSyncWithFoo deleted the rk-annotated branch December 13, 2024 17:50
@InSyncWithFoo InSyncWithFoo mentioned this pull request Dec 13, 2024
Merged
carljm pushed a commit that referenced this pull request Dec 13, 2024
@InSyncWithFoo
[red-knot] Alphabetize rules (#14960)
9798556 
## Summary

Follow-up from #14950.

## Test Plan

Purely stylistic change. Shouldn't affect any functionalities.
dcreager added a commit that referenced this pull request Dec 13, 2024
@dcreager
Merge branch 'main' into dcreager/module-resolution
7ae011c 
* main:
  [red-knot] Use `type[Unknown]` rather than `Unknown` as the fallback metaclass for invalid classes (#14961)
  [red-knot] Make `is_subtype_of` exhaustive (#14924)
  [red-knot] Alphabetize rules (#14960)
  [red-knot] Understand `Annotated` (#14950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

@sharkdp sharkdp Awaiting requested review from sharkdp

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[red-knot] Understand Annotated

4 participants

@InSyncWithFoo @carljm @AlexWaygood @MichaReiser