[red-knot] Fixes to Type::to_meta_type#14942
Merged
AlexWaygood merged 1 commit intomainfrom Dec 12, 2024
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a symbol
xhas typeAny,x.__class__should still be a dynamic, unknown type. However, that doesn't mean that it has to beAnyexactly. We know that for any objectx,x.__class__will be an instance oftype; ifxhas typeAny, this still holds true, we just don't know which exact instance oftypewe have forx.__class__. This can be expressed using the typetype[Any].To implement these semantics, this PR modifies
Type::to_meta_typeso that the meta-type ofAnyistype[Any], the meta-type ofUnknownistype[Unknown]and the meta-type ofTodoistype[Todo].Test Plan
New mdtests added