Conversation
Collaborator
Author
|
Thanks @msiglreith, seems we can update to rust-windowing/raw-window-metal#4 (v0.2) without any other changes (though the CI doesn't build-test a mac/ios build afaik). |
Closed
|
What is this waiting on? |
Collaborator
Author
|
@dvc94ch As long as we stick on 0.3.4, this crate can be used with both the 0.3.4 and 0.4.1 |
|
Not quite sure what you mean, this is the error I get with the winit provided handle: |
Collaborator
Author
e10bed8 to
7aa6bbc
Compare
339f864 to
3327818
Compare
Ralith
approved these changes
Jul 29, 2022
The match arms are not guarded by `cfg` anymore, allowing us to compile-test these simple arms on every system whenever our Ash extension helpers and types are not guarded by `cfg` attributes either. This applies to every platform except Mac/IOS where the symbols and external raw-window-metal crate are themselves guarded by cfg's.
MarijnS95
added a commit
that referenced
this pull request
Jul 29, 2022
The match arms are not guarded by `cfg` anymore, allowing us to compile-test these simple arms on every system whenever our Ash extension helpers and types are not guarded by `cfg` attributes either. This applies to every platform except Mac/IOS where the symbols and external raw-window-metal crate are themselves guarded by cfg's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this depends on one of the many winit 0.25 example upgrades (though we'll require 0.26 to make
raw-window-handle0.4 work) in order to succeed compilation on the examples.Not sure about the timing on this one: raw-window-handle just came out, and winit 0.26 too. There's a compatibility in 0.3.4 that allows consumers like this ash-window crate to consume the 0.4 handle (because the trait is implemented for it) produced by ie. winit, so there's a good reason to stay on 0.3.4 for longer to have wider adoption before migrating the ash-window crate - which is unfortunately tied in to the ash version! This just provides a git branch/rev for crate authors to use if they desire to deduplicate their raw-window-handle dependency in the crate graph.
I wonder if we can use a lower and upper version bound on ash and just perform minor releases of ash-window to increase that upper bound whenever a new, compatible version of ash is released. A bit like the proposed fixes for vma. We can keep two ash-window major releases in parallel, but that's going to get hairy as soon as there's a breaking change in ash (in fact the unreleased "Support linking vulkan directly" PR changes our API surface already).
The match arms are not guarded by
cfganymore, allowing us to compile-test these simple arms on every system whenever our Ash extension helpers and types are not guarded bycfgattributes either. This applies to every platform except Mac/IOS where the symbols and external raw-window-metal crate are themselves guarded by cfg's.CC @msiglreith, seems like we need an update to https://github.com/norse-rs/raw-window-metal before this could even work :)