Update raw-window-handle dep to 0.4.2.#4
Merged
msiglreith merged 2 commits intomasterfrom Dec 2, 2021
Merged
Conversation
Rename `macos` -> `appkit` and `ios` -> `uikit` following `raw-window-handle`.
Member
Author
|
cc @MarijnS95 I would probably publish it tomorrow after work |
MarijnS95
reviewed
Jul 28, 2022
Comment on lines
6
to
+9
| #[cfg(target_os = "macos")] | ||
| pub mod macos; | ||
| pub mod appkit; | ||
| #[cfg(target_os = "ios")] | ||
| pub mod ios; | ||
| pub mod uikit; |
Member
There was a problem hiding this comment.
@msiglreith I've been looking into reviving the related ash-window PR now that raw-window-handle 0.5 is out and used in winit 0.27, and stumbled upon these cfgs. According to https://github.com/rust-windowing/raw-window-handle/pull/70/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759 (surprisingly the author detailed/justified nothing of this in PR/commit messages...) it should be possible to use these across macos and ios now when targeting "Mac Catalyst"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.