Skip to content

KAFKA-9024: Better error message when field specified does not exist#7819

Merged
rhauch merged 1 commit into
apache:trunkfrom
ncliang:trunk
Jan 21, 2020
Merged

KAFKA-9024: Better error message when field specified does not exist#7819
rhauch merged 1 commit into
apache:trunkfrom
ncliang:trunk

Conversation

@ncliang

@ncliang ncliang commented Dec 11, 2019

Copy link
Copy Markdown
Contributor

Throw a DataException with informative error message when a field does not exist. This is better than current behavior of throwing NPE.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ncliang

ncliang commented Dec 11, 2019

Copy link
Copy Markdown
Contributor Author

@rhauch I think this can go as far back as 1.0 without merge conflicts. Not sure if we want to target earlier than that, but we probably could.

@ncliang

ncliang commented Dec 17, 2019

Copy link
Copy Markdown
Contributor Author

@kkonstantine

@ncliang

ncliang commented Dec 21, 2019

Copy link
Copy Markdown
Contributor Author

retest this please

@rhauch rhauch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ncliang.

@rhauch rhauch merged commit 28f0137 into apache:trunk Jan 21, 2020
rhauch pushed a commit that referenced this pull request Jan 21, 2020
…7819)

Author: Nigel Liang <nigel@nigelliang.com>
Reviewer: Randall Hauch <rhauch@gmail.com>
rhauch pushed a commit that referenced this pull request Jan 21, 2020
…7819)

Author: Nigel Liang <nigel@nigelliang.com>
Reviewer: Randall Hauch <rhauch@gmail.com>
rhauch pushed a commit that referenced this pull request Jan 21, 2020
…7819)

Author: Nigel Liang <nigel@nigelliang.com>
Reviewer: Randall Hauch <rhauch@gmail.com>
ijuma added a commit to confluentinc/kafka that referenced this pull request Jan 23, 2020
* apache-github/trunk:
  KAFKA-9418; Add new sendOffsetsToTransaction API to KafkaProducer (apache#7952)
  KAFKA-7273 Clarification on mutability of headers passed to Converter#fromConnectData() (apache#7489)
  MINOR: Only update a request's local complete time in API handler if unset (apache#7813)
  KAFKA-9143: Log task reconfiguration error only when it happened (apache#7648)
  MINOR: Change the log level from ERROR to DEBUG when failing to get plugin loader for connector (apache#7964)
  KAFKA-9024: Better error message when field specified does not exist (apache#7819)
  KAFKA-7204: Avoid clearing records for paused partitions on poll of MockConsumer (apache#7505)
  KAFKA-9083: Various fixes/improvements for Connect's Values class (apache#7593)
  MINOR: log error message from Connect sink exception (apache#7555)
qq619618919 pushed a commit to qq619618919/kafka that referenced this pull request May 12, 2020
…pache#7819)

Author: Nigel Liang <nigel@nigelliang.com>
Reviewer: Randall Hauch <rhauch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants