KAFKA-7273 Clarification on mutability of headers passed to Converter…#7489
Merged
Conversation
…#fromConnectData()
Contributor
Author
|
@rhauch, hey there; perhaps you could pull this in for the next release? Minor JavaDoc clarification. |
Contributor
Author
|
@rhauch, ping? |
Contributor
|
Thanks, @gunnarmorling. We're past code freeze for AK 2.4, so I've been holding off on this until we're past that so that this can be backported. It is a relatively benign change, but not important enough to request a fix. I could merge this to |
rhauch
approved these changes
Nov 7, 2019
rhauch
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks, @gunnarmorling.
Contributor
|
Retest this, please. |
Contributor
|
Retest this please |
Contributor
|
This PR only includes one small JavaDoc changes, and the test failures are completely unrelated. |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Jan 23, 2020
* apache-github/trunk: KAFKA-9418; Add new sendOffsetsToTransaction API to KafkaProducer (apache#7952) KAFKA-7273 Clarification on mutability of headers passed to Converter#fromConnectData() (apache#7489) MINOR: Only update a request's local complete time in API handler if unset (apache#7813) KAFKA-9143: Log task reconfiguration error only when it happened (apache#7648) MINOR: Change the log level from ERROR to DEBUG when failing to get plugin loader for connector (apache#7964) KAFKA-9024: Better error message when field specified does not exist (apache#7819) KAFKA-7204: Avoid clearing records for paused partitions on poll of MockConsumer (apache#7505) KAFKA-9083: Various fixes/improvements for Connect's Values class (apache#7593) MINOR: log error message from Connect sink exception (apache#7555)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#fromConnectData()