KAFKA-9143: Log task reconfiguration error only when it happened#7648
Merged
rhauch merged 1 commit intoJan 21, 2020
Merged
Conversation
This commit makes `DistributedHerder` log that some error has happened during task reconfiguration only when it actually has happened.
Contributor
Author
|
It needs another approval. I'd like to tag @ewencp as the author of the original piece. |
Contributor
|
@ivanyu this PR does not need another approval, since I am a committer. However, we're currently in AK 2.4 code freeze, so I was holding off merging since we want to backport this to the |
andrewchoi5
approved these changes
Dec 12, 2019
Contributor
Author
|
@rhauch any chance merging this now? |
rhauch
pushed a commit
that referenced
this pull request
Jan 21, 2020
This commit makes `DistributedHerder` log that some error has happened during task reconfiguration only when it actually has happened. Author: Ivan Yurchenko <ivan0yurchenko@gmail.com> Reviewer: Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Jan 21, 2020
This commit makes `DistributedHerder` log that some error has happened during task reconfiguration only when it actually has happened. Author: Ivan Yurchenko <ivan0yurchenko@gmail.com> Reviewer: Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Jan 21, 2020
This commit makes `DistributedHerder` log that some error has happened during task reconfiguration only when it actually has happened. Author: Ivan Yurchenko <ivan0yurchenko@gmail.com> Reviewer: Randall Hauch <rhauch@gmail.com>
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Jan 23, 2020
* apache-github/trunk: KAFKA-9418; Add new sendOffsetsToTransaction API to KafkaProducer (apache#7952) KAFKA-7273 Clarification on mutability of headers passed to Converter#fromConnectData() (apache#7489) MINOR: Only update a request's local complete time in API handler if unset (apache#7813) KAFKA-9143: Log task reconfiguration error only when it happened (apache#7648) MINOR: Change the log level from ERROR to DEBUG when failing to get plugin loader for connector (apache#7964) KAFKA-9024: Better error message when field specified does not exist (apache#7819) KAFKA-7204: Avoid clearing records for paused partitions on poll of MockConsumer (apache#7505) KAFKA-9083: Various fixes/improvements for Connect's Values class (apache#7593) MINOR: log error message from Connect sink exception (apache#7555)
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
…che#7648) This commit makes `DistributedHerder` log that some error has happened during task reconfiguration only when it actually has happened. Author: Ivan Yurchenko <ivan0yurchenko@gmail.com> Reviewer: Randall Hauch <rhauch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes
DistributedHerderlog that some error has happened during task reconfiguration only when it actually has happened.More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)