-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](p0) Remove dependency on pre-existing doris_test database in binary digest test #58291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
zclllyybb
approved these changes
Nov 25, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
approved these changes
Nov 28, 2025
Contributor
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
…nary digest test (#58291) Related PR: #56497 Problem Summary: The test `test_binary_for_digest` was failing when running Regression External tests because it depended on a pre-existing `doris_test` database in the external MySQL instance. This database is only created during query_p0 test suite execution, which will cause error: ```text Exception in query_p0/sql_functions/encryption_digest/test_binary_for_digest.groovy(line 51): connect("root", "123456", "jdbc:mysql://${externalEnvIp}:${mysql_port}/doris_test?useSSL=false") { try_sql """DROP TABLE IF EXISTS ${test_table}""" sql """CREATE TABLE ${test_table} ( id int, vb varbinary(100), vc VARCHAR(100) )""" sql """INSERT INTO ${test_table} VALUES ^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^ (1, 'hello world', 'hello world'), (2, 'test data', 'test data'), (3, 'hash test', 'hash test'), (4, '', ''), (5, 'special chars: !@#%', 'special chars: !@#%')""" } sql """switch ${catalog_name}""" sql """use ${ex_db_name}""" Exception: java.sql.SQLSyntaxErrorException: Table 'doris_test.binary_test' doesn't exist ``` Now creates `binary_for_digest_test` database at test startup instead of relying on `doris_test`.
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
…nary digest test (apache#58291) Related PR: apache#56497 Problem Summary: The test `test_binary_for_digest` was failing when running Regression External tests because it depended on a pre-existing `doris_test` database in the external MySQL instance. This database is only created during query_p0 test suite execution, which will cause error: ```text Exception in query_p0/sql_functions/encryption_digest/test_binary_for_digest.groovy(line 51): connect("root", "123456", "jdbc:mysql://${externalEnvIp}:${mysql_port}/doris_test?useSSL=false") { try_sql """DROP TABLE IF EXISTS ${test_table}""" sql """CREATE TABLE ${test_table} ( id int, vb varbinary(100), vc VARCHAR(100) )""" sql """INSERT INTO ${test_table} VALUES ^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^ (1, 'hello world', 'hello world'), (2, 'test data', 'test data'), (3, 'hash test', 'hash test'), (4, '', ''), (5, 'special chars: !@#%', 'special chars: !@#%')""" } sql """switch ${catalog_name}""" sql """use ${ex_db_name}""" Exception: java.sql.SQLSyntaxErrorException: Table 'doris_test.binary_test' doesn't exist ``` Now creates `binary_for_digest_test` database at test startup instead of relying on `doris_test`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #56497
Problem Summary:
The test
test_binary_for_digestwas failing when running Regression External tests because it depended on a pre-existingdoris_testdatabase in the external MySQL instance. This database is only created during query_p0 test suite execution, which will cause error:Now creates
binary_for_digest_testdatabase at test startup instead of relying ondoris_test.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)