-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Feature](varbinary) Extend the digest function for VarBinary type #56497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
2a70892 to
b6663e4
Compare
b6663e4 to
d0d9201
Compare
|
run buildall |
ClickBench: Total hot run time: 30.71 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
ClickBench: Total hot run time: 30.44 s |
FE UT Coverage ReportIncrement line coverage |
036975b to
8abd676
Compare
|
run buildall |
ClickBench: Total hot run time: 30.32 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
8abd676 to
0bb03ee
Compare
|
run buildall |
ClickBench: Total hot run time: 29.95 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run performance |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run performance |
zclllyybb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
ClickBench: Total hot run time: 30.14 s |
…56497) Doris has add a new datatype about binary, this pr extend the digest function to support VarBinary type parameter.
…nary digest test (#58291) Related PR: #56497 Problem Summary: The test `test_binary_for_digest` was failing when running Regression External tests because it depended on a pre-existing `doris_test` database in the external MySQL instance. This database is only created during query_p0 test suite execution, which will cause error: ```text Exception in query_p0/sql_functions/encryption_digest/test_binary_for_digest.groovy(line 51): connect("root", "123456", "jdbc:mysql://${externalEnvIp}:${mysql_port}/doris_test?useSSL=false") { try_sql """DROP TABLE IF EXISTS ${test_table}""" sql """CREATE TABLE ${test_table} ( id int, vb varbinary(100), vc VARCHAR(100) )""" sql """INSERT INTO ${test_table} VALUES ^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^ (1, 'hello world', 'hello world'), (2, 'test data', 'test data'), (3, 'hash test', 'hash test'), (4, '', ''), (5, 'special chars: !@#%', 'special chars: !@#%')""" } sql """switch ${catalog_name}""" sql """use ${ex_db_name}""" Exception: java.sql.SQLSyntaxErrorException: Table 'doris_test.binary_test' doesn't exist ``` Now creates `binary_for_digest_test` database at test startup instead of relying on `doris_test`.
…nary digest test (#58291) Related PR: #56497 Problem Summary: The test `test_binary_for_digest` was failing when running Regression External tests because it depended on a pre-existing `doris_test` database in the external MySQL instance. This database is only created during query_p0 test suite execution, which will cause error: ```text Exception in query_p0/sql_functions/encryption_digest/test_binary_for_digest.groovy(line 51): connect("root", "123456", "jdbc:mysql://${externalEnvIp}:${mysql_port}/doris_test?useSSL=false") { try_sql """DROP TABLE IF EXISTS ${test_table}""" sql """CREATE TABLE ${test_table} ( id int, vb varbinary(100), vc VARCHAR(100) )""" sql """INSERT INTO ${test_table} VALUES ^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^ (1, 'hello world', 'hello world'), (2, 'test data', 'test data'), (3, 'hash test', 'hash test'), (4, '', ''), (5, 'special chars: !@#%', 'special chars: !@#%')""" } sql """switch ${catalog_name}""" sql """use ${ex_db_name}""" Exception: java.sql.SQLSyntaxErrorException: Table 'doris_test.binary_test' doesn't exist ``` Now creates `binary_for_digest_test` database at test startup instead of relying on `doris_test`.
…nary digest test (apache#58291) Related PR: apache#56497 Problem Summary: The test `test_binary_for_digest` was failing when running Regression External tests because it depended on a pre-existing `doris_test` database in the external MySQL instance. This database is only created during query_p0 test suite execution, which will cause error: ```text Exception in query_p0/sql_functions/encryption_digest/test_binary_for_digest.groovy(line 51): connect("root", "123456", "jdbc:mysql://${externalEnvIp}:${mysql_port}/doris_test?useSSL=false") { try_sql """DROP TABLE IF EXISTS ${test_table}""" sql """CREATE TABLE ${test_table} ( id int, vb varbinary(100), vc VARCHAR(100) )""" sql """INSERT INTO ${test_table} VALUES ^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^ (1, 'hello world', 'hello world'), (2, 'test data', 'test data'), (3, 'hash test', 'hash test'), (4, '', ''), (5, 'special chars: !@#%', 'special chars: !@#%')""" } sql """switch ${catalog_name}""" sql """use ${ex_db_name}""" Exception: java.sql.SQLSyntaxErrorException: Table 'doris_test.binary_test' doesn't exist ``` Now creates `binary_for_digest_test` database at test startup instead of relying on `doris_test`.
What problem does this PR solve?
Issue Number: close #56426
Related PR: #xxx
Problem Summary:
Doris has add a new datatype about binary, this pr extend the digest function to support VarBinary type parameter.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)