Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #58291

…nary digest test (#58291)

Related PR: #56497

Problem Summary:

The test `test_binary_for_digest` was failing when running Regression
External tests because it depended on a pre-existing `doris_test`
database in the external MySQL instance. This database is only created
during query_p0 test suite execution, which will cause error:
```text
Exception in query_p0/sql_functions/encryption_digest/test_binary_for_digest.groovy(line 51):

        connect("root", "123456", "jdbc:mysql://${externalEnvIp}:${mysql_port}/doris_test?useSSL=false") {
            try_sql """DROP TABLE IF EXISTS ${test_table}"""

            sql """CREATE TABLE ${test_table} (
                id int,
                vb varbinary(100),
                vc VARCHAR(100)
            )"""

            sql """INSERT INTO ${test_table} VALUES 
^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^
                (1, 'hello world', 'hello world'),
                (2, 'test data', 'test data'),
                (3, 'hash test', 'hash test'),
                (4, '', ''),
                (5, 'special chars: !@#%', 'special chars: !@#%')"""
        }

        sql """switch ${catalog_name}"""
        sql """use ${ex_db_name}"""


Exception:
java.sql.SQLSyntaxErrorException: Table 'doris_test.binary_test' doesn't exist
```

Now creates `binary_for_digest_test` database at test startup instead of
relying on `doris_test`.
@github-actions github-actions bot requested a review from yiguolei as a code owner November 28, 2025 07:51
@Thearas
Copy link
Contributor

Thearas commented Nov 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 28, 2025
@Thearas
Copy link
Contributor

Thearas commented Nov 28, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2025
@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit cadeb78 into branch-4.0 Nov 28, 2025
26 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-58291-branch-4.0 branch November 28, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants