Skip to content

[fix](mtmv)Restricting the use of external views to create MTMV #57759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 16 commits into from
Nov 10, 2025
Merged

[fix](mtmv)Restricting the use of external views to create MTMV #57759

morrySnow merged 16 commits into from
Nov 10, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Nov 6, 2025 •
edited
Loading

What problem does this PR solve?

  • Restricting the use of external views to create MTMV
  • add case
  • fix display of mv_infos

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Restricting the use of external views to create MTMV

Release note

Restricting the use of external views to create MTMV

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Nov 6, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 6, 2025

TPC-DS: Total hot run time: 188573 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b316cbc5d3468ae8ee24277bb3d43ebfb3fa95e7, data reload: false

query1	1030	427	401	401
query2	6574	1701	1713	1701
query3	6759	224	214	214
query4	26450	23821	22936	22936
query5	5581	606	447	447
query6	335	235	218	218
query7	4645	482	294	294
query8	310	263	244	244
query9	8694	2563	2558	2558
query10	541	338	310	310
query11	15255	15048	14837	14837
query12	186	121	109	109
query13	1698	545	446	446
query14	11353	9184	9063	9063
query15	197	196	176	176
query16	7648	673	488	488
query17	1296	721	609	609
query18	2023	409	337	337
query19	320	233	179	179
query20	140	134	135	134
query21	212	151	133	133
query22	4473	4642	4580	4580
query23	34465	33657	33838	33657
query24	8665	2481	2526	2481
query25	642	600	499	499
query26	1313	312	159	159
query27	2805	574	354	354
query28	4675	2272	2187	2187
query29	844	626	517	517
query30	340	231	205	205
query31	943	867	761	761
query32	89	74	71	71
query33	647	392	360	360
query34	816	879	526	526
query35	834	898	829	829
query36	984	1052	915	915
query37	116	105	80	80
query38	3490	3600	3496	3496
query39	1435	1413	1405	1405
query40	215	126	125	125
query41	58	55	58	55
query42	123	107	108	107
query43	484	484	459	459
query44	1205	758	738	738
query45	179	174	169	169
query46	876	975	630	630
query47	1732	1768	1734	1734
query48	378	445	313	313
query49	772	502	397	397
query50	628	681	398	398
query51	3842	4074	3937	3937
query52	108	107	97	97
query53	225	255	194	194
query54	328	300	275	275
query55	83	83	86	83
query56	302	314	302	302
query57	1185	1200	1123	1123
query58	282	268	263	263
query59	2618	2703	2497	2497
query60	360	348	357	348
query61	156	156	174	156
query62	795	732	655	655
query63	232	190	191	190
query64	4442	1223	946	946
query65	4009	4009	3924	3924
query66	1048	452	354	354
query67	15388	15204	14937	14937
query68	6533	881	612	612
query69	492	329	300	300
query70	1335	1185	1254	1185
query71	470	334	334	334
query72	6256	5079	4903	4903
query73	657	572	359	359
query74	8830	9028	8847	8847
query75	3312	3317	2878	2878
query76	3222	1171	718	718
query77	500	406	321	321
query78	9575	9783	8796	8796
query79	2755	847	585	585
query80	691	570	517	517
query81	503	260	224	224
query82	336	158	126	126
query83	266	254	248	248
query84	258	110	92	92
query85	881	483	429	429
query86	352	312	286	286
query87	3646	3737	3651	3651
query88	4054	2243	2230	2230
query89	382	333	290	290
query90	2142	217	220	217
query91	158	160	135	135
query92	84	63	62	62
query93	2558	977	634	634
query94	708	455	342	342
query95	394	306	305	305
query96	481	563	275	275
query97	2910	2991	2873	2873
query98	238	209	207	207
query99	1322	1380	1270	1270
Total cold run time: 277177 ms
Total hot run time: 188573 ms

@doris-robot
Copy link

doris-robot commented Nov 6, 2025

ClickBench: Total hot run time: 27.54 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b316cbc5d3468ae8ee24277bb3d43ebfb3fa95e7, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.04	0.05
query3	0.25	0.08	0.08
query4	1.60	0.11	0.12
query5	0.28	0.26	0.25
query6	1.17	0.64	0.64
query7	0.04	0.03	0.03
query8	0.06	0.05	0.04
query9	0.61	0.52	0.51
query10	0.59	0.57	0.58
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	1.01	0.99	1.01
query15	0.85	0.82	0.84
query16	0.39	0.38	0.39
query17	1.01	1.04	1.03
query18	0.21	0.20	0.20
query19	1.92	1.83	1.79
query20	0.02	0.04	0.02
query21	15.44	0.19	0.14
query22	4.98	0.07	0.04
query23	15.65	0.25	0.10
query24	3.11	0.48	1.10
query25	0.08	0.07	0.06
query26	0.15	0.13	0.13
query27	0.05	0.06	0.06
query28	5.34	1.14	0.93
query29	12.57	3.88	3.28
query30	0.28	0.14	0.14
query31	2.81	0.59	0.38
query32	3.23	0.55	0.46
query33	2.98	3.11	2.99
query34	15.70	5.16	4.55
query35	4.53	4.55	4.61
query36	0.67	0.50	0.50
query37	0.09	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.13
query41	0.09	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 99.21 s
Total hot run time: 27.54 s

@zddr
Copy link
Contributor Author

zddr commented Nov 7, 2025

run feut

@zddr
Copy link
Contributor Author

zddr commented Nov 7, 2025

run external

1 similar comment
@zddr
Copy link
Contributor Author

zddr commented Nov 7, 2025

run external

@zddr
Copy link
Contributor Author

zddr commented Nov 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 7, 2025

TPC-H: Total hot run time: 34170 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be27057a7cfe1bf3e1f3f9ac566353bc91dd6440, data reload: false

------ Round 1 ----------------------------------
q1	17635	5274	5054	5054
q2	2020	323	216	216
q3	10287	1291	701	701
q4	10211	849	357	357
q5	7506	2445	2319	2319
q6	179	169	135	135
q7	949	758	616	616
q8	9338	1348	1119	1119
q9	7024	5159	5176	5159
q10	6833	2211	1793	1793
q11	486	304	277	277
q12	339	371	227	227
q13	17797	3621	3027	3027
q14	251	229	205	205
q15	557	492	517	492
q16	1020	1009	948	948
q17	604	876	368	368
q18	7630	7120	7083	7083
q19	1256	948	572	572
q20	363	335	228	228
q21	4233	3243	2301	2301
q22	1081	1057	973	973
Total cold run time: 107599 ms
Total hot run time: 34170 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5204	5134	5130	5130
q2	245	323	234	234
q3	2195	2694	2340	2340
q4	1412	1781	1387	1387
q5	4211	4584	4632	4584
q6	222	167	132	132
q7	2041	1924	1819	1819
q8	2647	2679	2638	2638
q9	7477	7215	7303	7215
q10	3020	3239	2777	2777
q11	600	540	511	511
q12	668	814	653	653
q13	3571	3965	3352	3352
q14	295	318	297	297
q15	529	530	496	496
q16	1081	1136	1057	1057
q17	1182	1539	1398	1398
q18	8034	7634	7601	7601
q19	860	878	929	878
q20	1981	2047	1943	1943
q21	4882	4420	4317	4317
q22	1082	1058	995	995
Total cold run time: 53439 ms
Total hot run time: 51754 ms

@doris-robot
Copy link

doris-robot commented Nov 7, 2025

TPC-DS: Total hot run time: 187141 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be27057a7cfe1bf3e1f3f9ac566353bc91dd6440, data reload: false

query1	1044	410	401	401
query2	6599	1729	1699	1699
query3	6752	222	223	222
query4	26936	23251	23480	23251
query5	5728	617	476	476
query6	325	240	219	219
query7	4652	495	292	292
query8	299	255	252	252
query9	8692	2592	2564	2564
query10	573	325	283	283
query11	15346	15056	14811	14811
query12	188	119	111	111
query13	1679	571	467	467
query14	11508	9345	9222	9222
query15	220	191	176	176
query16	7749	697	546	546
query17	1649	802	633	633
query18	2056	435	337	337
query19	286	208	181	181
query20	142	122	121	121
query21	205	128	115	115
query22	3971	4200	3983	3983
query23	34215	32948	32894	32894
query24	8316	2386	2440	2386
query25	576	538	450	450
query26	1224	269	158	158
query27	2727	496	350	350
query28	4319	2222	2193	2193
query29	791	647	490	490
query30	304	234	197	197
query31	898	810	733	733
query32	82	78	69	69
query33	594	383	322	322
query34	784	853	519	519
query35	800	841	726	726
query36	954	966	870	870
query37	120	110	86	86
query38	3497	3544	3443	3443
query39	1460	1408	1409	1408
query40	218	135	118	118
query41	61	59	63	59
query42	125	120	110	110
query43	498	494	461	461
query44	1229	738	749	738
query45	183	187	179	179
query46	882	993	632	632
query47	1756	1765	1702	1702
query48	391	420	312	312
query49	786	518	467	467
query50	642	686	398	398
query51	3898	3824	3824	3824
query52	113	121	106	106
query53	234	280	203	203
query54	308	293	276	276
query55	87	89	86	86
query56	313	307	311	307
query57	1177	1188	1130	1130
query58	290	282	268	268
query59	2536	2659	2490	2490
query60	347	353	324	324
query61	191	158	167	158
query62	805	714	677	677
query63	226	189	197	189
query64	4477	1203	949	949
query65	4051	3927	4012	3927
query66	1059	460	360	360
query67	15445	15078	15118	15078
query68	8201	923	601	601
query69	555	314	286	286
query70	1351	1255	1263	1255
query71	456	338	311	311
query72	5804	4859	4804	4804
query73	635	559	367	367
query74	9241	8969	8620	8620
query75	3551	3297	2819	2819
query76	3520	1134	727	727
query77	698	394	317	317
query78	9620	9707	8813	8813
query79	2467	826	604	604
query80	703	557	486	486
query81	504	268	233	233
query82	228	169	134	134
query83	272	262	250	250
query84	263	117	96	96
query85	886	485	441	441
query86	334	312	319	312
query87	3659	3702	3580	3580
query88	3918	2218	2236	2218
query89	392	330	300	300
query90	1922	219	217	217
query91	169	172	144	144
query92	92	70	64	64
query93	2132	999	637	637
query94	708	444	337	337
query95	395	323	311	311
query96	484	563	276	276
query97	2890	2960	2886	2886
query98	240	216	232	216
query99	1368	1398	1295	1295
Total cold run time: 278246 ms
Total hot run time: 187141 ms

@doris-robot
Copy link

doris-robot commented Nov 7, 2025

ClickBench: Total hot run time: 27.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be27057a7cfe1bf3e1f3f9ac566353bc91dd6440, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.04	0.04
query3	0.27	0.09	0.08
query4	1.61	0.11	0.11
query5	0.27	0.26	0.26
query6	1.19	0.65	0.65
query7	0.04	0.03	0.02
query8	0.06	0.04	0.05
query9	0.59	0.52	0.51
query10	0.57	0.57	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.60	0.61
query14	1.01	0.99	1.01
query15	0.85	0.84	0.86
query16	0.38	0.39	0.39
query17	1.01	1.03	1.04
query18	0.21	0.20	0.19
query19	1.92	1.76	1.82
query20	0.01	0.01	0.01
query21	15.49	0.20	0.13
query22	5.01	0.06	0.05
query23	15.66	0.26	0.10
query24	2.83	0.67	0.59
query25	0.07	0.06	0.05
query26	0.14	0.13	0.15
query27	0.07	0.06	0.05
query28	4.72	1.11	0.94
query29	12.54	3.89	3.25
query30	0.27	0.14	0.11
query31	2.81	0.59	0.38
query32	3.23	0.54	0.47
query33	3.00	3.04	3.09
query34	15.95	5.17	4.58
query35	4.56	4.58	4.55
query36	0.69	0.50	0.49
query37	0.09	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.15	0.15
query41	0.08	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.63 s
Total hot run time: 27.65 s

@zddr
Copy link
Contributor Author

zddr commented Nov 7, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 7, 2025

FE Regression Coverage Report

Increment line coverage 69.23% (9/13) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 7, 2025

FE Regression Coverage Report

Increment line coverage 69.23% (9/13) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit a284e2a into apache:master Nov 10, 2025
29 of 30 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@zddr @wyxxxcat
[fix](mtmv)Restricting the use of external views to create MTMV (apac…
f3b3026 
…he#57759)

- Restricting the use of external views to create MTMV
- add case
- fix display of mv_infos
zddr added a commit to zddr/incubator-doris that referenced this pull request Nov 19, 2025
@zddr
[fix](mtmv)Restricting the use of external views to create MTMV (apac…
e2c7a30 
…he#57759)

- Restricting the use of external views to create MTMV
- add case
- fix display of mv_infos
@zddr zddr mentioned this pull request Nov 19, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 20, 2025
@zddr @seawinde
branch-4.0:[feature](mtmv)MTMV refresh support multi pct tables (#58140)
1d63c19 
pick: #56958
#57713
#57759
#57681
#57958

---------

Co-authored-by: seawinde <daydayup005@yeah.net>
Co-authored-by: seawinde <wusi@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@seawinde seawinde seawinde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zddr @hello-stephen @doris-robot @morrySnow @seawinde @yiguolei