Skip to content

[fix](mtmv) Fix multi materialized view input trigger refresh fail when exists alias #57681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Nov 11, 2025
Merged

[fix](mtmv) Fix multi materialized view input trigger refresh fail when exists alias #57681

morrySnow merged 2 commits into from
Nov 11, 2025

Conversation

@seawinde
Copy link
Contributor

@seawinde seawinde commented Nov 4, 2025

What problem does this PR solve?

Fix some bugs when multi materialized view input trigger refresh

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@seawinde
Copy link
Contributor Author

seawinde commented Nov 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 4, 2025

TPC-DS: Total hot run time: 189275 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 71501014b34e1ce409c3d49c2a26641f62a28164, data reload: false

query1	1057	396	383	383
query2	6551	1693	1704	1693
query3	6747	221	222	221
query4	26329	23712	23106	23106
query5	5214	640	469	469
query6	324	228	209	209
query7	4654	494	296	296
query8	322	272	251	251
query9	8722	2580	2581	2580
query10	547	379	289	289
query11	15479	15063	14979	14979
query12	183	118	116	116
query13	1706	587	465	465
query14	11506	9437	9444	9437
query15	205	194	185	185
query16	7674	691	468	468
query17	1619	792	638	638
query18	2069	442	355	355
query19	218	219	180	180
query20	139	133	131	131
query21	249	161	134	134
query22	4653	4450	4774	4450
query23	35125	33888	33767	33767
query24	8810	2499	2538	2499
query25	603	549	497	497
query26	1425	287	174	174
query27	3763	517	359	359
query28	4532	2289	2257	2257
query29	915	656	543	543
query30	306	224	201	201
query31	951	820	802	802
query32	82	72	77	72
query33	600	387	327	327
query34	827	938	617	617
query35	812	861	769	769
query36	969	1021	909	909
query37	136	121	85	85
query38	3745	3641	3454	3454
query39	1457	1383	1407	1383
query40	217	124	116	116
query41	60	56	61	56
query42	118	107	107	107
query43	495	488	447	447
query44	1206	731	736	731
query45	187	173	176	173
query46	884	996	654	654
query47	1730	1805	1710	1710
query48	386	407	307	307
query49	770	486	437	437
query50	632	680	396	396
query51	3896	3865	3757	3757
query52	105	107	102	102
query53	230	261	193	193
query54	311	283	268	268
query55	83	86	80	80
query56	319	310	304	304
query57	1149	1173	1135	1135
query58	283	276	269	269
query59	2549	2664	2501	2501
query60	351	329	324	324
query61	154	154	152	152
query62	784	707	664	664
query63	227	188	190	188
query64	4461	1270	960	960
query65	4032	3974	3918	3918
query66	1102	450	348	348
query67	15130	15051	15089	15051
query68	8240	932	596	596
query69	510	343	294	294
query70	1331	1327	1323	1323
query71	469	339	313	313
query72	6083	4857	4857	4857
query73	647	575	347	347
query74	8896	8890	8629	8629
query75	3366	3365	2850	2850
query76	3392	1130	736	736
query77	563	417	323	323
query78	9514	9693	8967	8967
query79	2671	821	589	589
query80	688	560	499	499
query81	517	262	229	229
query82	237	159	136	136
query83	268	258	244	244
query84	264	107	90	90
query85	875	480	435	435
query86	368	296	309	296
query87	3725	3673	3593	3593
query88	3959	2220	2189	2189
query89	373	322	297	297
query90	2055	213	229	213
query91	156	165	133	133
query92	80	68	60	60
query93	2464	959	631	631
query94	692	439	302	302
query95	393	329	318	318
query96	494	567	278	278
query97	2875	2960	2909	2909
query98	236	210	215	210
query99	1332	1405	1291	1291
Total cold run time: 280809 ms
Total hot run time: 189275 ms

@doris-robot
Copy link

doris-robot commented Nov 4, 2025

ClickBench: Total hot run time: 27.44 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 71501014b34e1ce409c3d49c2a26641f62a28164, data reload: false

query1	0.05	0.05	0.06
query2	0.09	0.05	0.05
query3	0.26	0.08	0.07
query4	1.60	0.12	0.11
query5	0.29	0.28	0.25
query6	1.17	0.65	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.59	0.52	0.52
query10	0.59	0.60	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	1.01	1.01	1.00
query15	0.84	0.84	0.85
query16	0.40	0.39	0.40
query17	1.02	1.03	0.99
query18	0.22	0.19	0.19
query19	1.96	1.84	1.85
query20	0.01	0.00	0.01
query21	15.44	0.19	0.13
query22	5.02	0.06	0.05
query23	15.74	0.26	0.10
query24	3.15	0.98	0.30
query25	0.07	0.06	0.06
query26	0.14	0.14	0.14
query27	0.06	0.06	0.05
query28	4.43	1.16	0.93
query29	12.62	3.92	3.23
query30	0.27	0.13	0.11
query31	2.81	0.59	0.38
query32	3.23	0.54	0.46
query33	3.12	3.10	3.10
query34	15.75	5.16	4.57
query35	4.57	4.58	4.58
query36	0.67	0.50	0.49
query37	0.09	0.06	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.04	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 98.72 s
Total hot run time: 27.44 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 4, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (4/4) 🎉
Increment coverage report
Complete coverage report

@seawinde seawinde force-pushed the fix_multi_input_mv_refresh_bug branch from 7150101 to f66b176 Compare November 6, 2025 11:55
@seawinde seawinde force-pushed the fix_multi_input_mv_refresh_bug branch from f66b176 to 867916b Compare November 6, 2025 11:56
@seawinde
Copy link
Contributor Author

seawinde commented Nov 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 10, 2025

TPC-H: Total hot run time: 34526 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2b3d61dc05d54d4376dcdb02952f8665c1984742, data reload: false

------ Round 1 ----------------------------------
q1	17619	5217	5044	5044
q2	2012	308	238	238
q3	10272	1276	727	727
q4	10250	898	373	373
q5	7522	2402	2348	2348
q6	191	172	138	138
q7	925	763	621	621
q8	9347	1329	1125	1125
q9	6879	5082	5117	5082
q10	6887	2256	1823	1823
q11	498	302	289	289
q12	373	365	236	236
q13	17778	3650	3028	3028
q14	231	232	223	223
q15	590	503	509	503
q16	999	1006	932	932
q17	596	867	370	370
q18	7329	7159	7109	7109
q19	1382	945	574	574
q20	347	341	217	217
q21	3811	2558	2933	2558
q22	1041	1009	968	968
Total cold run time: 106879 ms
Total hot run time: 34526 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5207	5130	5100	5100
q2	258	327	238	238
q3	2182	2706	2273	2273
q4	1368	1760	1367	1367
q5	4189	4519	4500	4500
q6	229	186	137	137
q7	2046	2001	1857	1857
q8	2700	2753	2579	2579
q9	7479	7346	7456	7346
q10	3034	3289	2820	2820
q11	611	531	505	505
q12	696	1040	647	647
q13	3433	3923	3457	3457
q14	276	304	291	291
q15	554	510	509	509
q16	1058	1101	1068	1068
q17	1204	1589	1410	1410
q18	7967	7797	7710	7710
q19	869	828	852	828
q20	1956	2028	1841	1841
q21	4765	4338	4358	4338
q22	1097	1060	984	984
Total cold run time: 53178 ms
Total hot run time: 51805 ms

@doris-robot
Copy link

doris-robot commented Nov 10, 2025

TPC-DS: Total hot run time: 188222 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2b3d61dc05d54d4376dcdb02952f8665c1984742, data reload: false

query1	1022	395	388	388
query2	6588	1668	1678	1668
query3	6759	224	219	219
query4	26316	23702	23444	23444
query5	4433	639	472	472
query6	354	253	238	238
query7	4650	495	298	298
query8	316	262	258	258
query9	8723	2615	2557	2557
query10	491	330	288	288
query11	15596	15077	14881	14881
query12	171	121	115	115
query13	1684	562	423	423
query14	10658	9316	9229	9229
query15	202	189	171	171
query16	7420	647	529	529
query17	1239	753	614	614
query18	1980	423	313	313
query19	211	203	183	183
query20	133	129	124	124
query21	215	135	116	116
query22	4167	4255	3963	3963
query23	33726	33242	33186	33186
query24	8515	2433	2452	2433
query25	636	533	466	466
query26	1251	278	173	173
query27	2735	504	358	358
query28	4405	2236	2193	2193
query29	848	643	507	507
query30	301	221	202	202
query31	919	813	689	689
query32	81	75	73	73
query33	620	396	337	337
query34	794	862	543	543
query35	817	867	752	752
query36	957	991	887	887
query37	123	115	87	87
query38	3550	3527	3501	3501
query39	1486	1427	1396	1396
query40	231	135	123	123
query41	68	69	68	68
query42	133	116	112	112
query43	504	493	463	463
query44	1263	764	739	739
query45	190	187	179	179
query46	874	991	645	645
query47	1745	1794	1723	1723
query48	399	439	328	328
query49	773	540	434	434
query50	643	683	409	409
query51	3842	4045	3912	3912
query52	113	111	101	101
query53	247	271	205	205
query54	334	300	318	300
query55	87	85	83	83
query56	317	334	311	311
query57	1185	1226	1125	1125
query58	294	279	276	276
query59	2595	2659	2535	2535
query60	342	338	334	334
query61	165	162	158	158
query62	821	733	678	678
query63	227	197	203	197
query64	4500	1158	843	843
query65	4010	3929	3949	3929
query66	1179	458	345	345
query67	15294	15320	14911	14911
query68	8317	943	603	603
query69	483	322	285	285
query70	1360	1287	1291	1287
query71	477	342	326	326
query72	6004	4952	4979	4952
query73	653	605	367	367
query74	9197	9062	8806	8806
query75	3919	3301	2814	2814
query76	3717	1151	778	778
query77	832	396	323	323
query78	9448	9750	8848	8848
query79	2878	861	596	596
query80	732	560	497	497
query81	490	254	227	227
query82	494	162	129	129
query83	300	261	258	258
query84	307	120	98	98
query85	947	478	442	442
query86	385	291	316	291
query87	3725	3646	3630	3630
query88	3568	2248	2234	2234
query89	411	338	297	297
query90	1951	222	240	222
query91	173	177	133	133
query92	79	67	65	65
query93	2408	981	642	642
query94	700	447	340	340
query95	411	329	316	316
query96	492	569	274	274
query97	2957	2977	2884	2884
query98	240	210	210	210
query99	1433	1406	1308	1308
Total cold run time: 276955 ms
Total hot run time: 188222 ms

@doris-robot
Copy link

doris-robot commented Nov 10, 2025

ClickBench: Total hot run time: 27.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2b3d61dc05d54d4376dcdb02952f8665c1984742, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.61	0.12	0.12
query5	0.27	0.25	0.25
query6	1.17	0.65	0.64
query7	0.03	0.03	0.02
query8	0.05	0.04	0.05
query9	0.59	0.51	0.52
query10	0.58	0.58	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.60	0.60
query14	1.00	0.99	0.99
query15	0.83	0.84	0.83
query16	0.39	0.39	0.38
query17	1.04	1.05	1.00
query18	0.22	0.21	0.20
query19	1.87	1.82	1.78
query20	0.02	0.01	0.01
query21	15.43	0.18	0.13
query22	5.13	0.06	0.04
query23	15.68	0.25	0.09
query24	2.76	0.63	0.92
query25	0.08	0.06	0.06
query26	0.14	0.13	0.12
query27	0.07	0.06	0.05
query28	4.78	1.14	0.94
query29	12.56	3.92	3.23
query30	0.29	0.14	0.12
query31	2.82	0.61	0.38
query32	3.24	0.56	0.47
query33	3.07	3.00	3.00
query34	15.83	5.18	4.58
query35	4.56	4.61	4.62
query36	0.69	0.50	0.49
query37	0.10	0.07	0.07
query38	0.06	0.05	0.03
query39	0.04	0.03	0.03
query40	0.18	0.15	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.7 s
Total hot run time: 27.61 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 10, 2025

FE Regression Coverage Report

Increment line coverage 85.71% (6/7) 🎉
Increment coverage report
Complete coverage report

@seawinde seawinde changed the title [draft](mtmv) Fix multi materialized view input trigger refresh fail when exists alias [fix](mtmv) Fix multi materialized view input trigger refresh fail when exists alias Nov 10, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 10, 2025

FE Regression Coverage Report

Increment line coverage 85.71% (6/7) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 10, 2025

FE Regression Coverage Report

Increment line coverage 85.71% (6/7) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit ecdad9c into apache:master Nov 11, 2025
28 of 30 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 13, 2025
@seawinde @wyxxxcat
[fix](mtmv) Fix multi materialized view input trigger refresh fail wh…
8b5f0de 
…en exists alias (apache#57681)
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@seawinde @wyxxxcat
[fix](mtmv) Fix multi materialized view input trigger refresh fail wh…
878101e 
…en exists alias (apache#57681)
zddr pushed a commit to zddr/incubator-doris that referenced this pull request Nov 19, 2025
@seawinde @zddr
[fix](mtmv) Fix multi materialized view input trigger refresh fail wh…
ad54c6b 
…en exists alias (apache#57681)
@zddr zddr mentioned this pull request Nov 19, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 20, 2025
@zddr @seawinde
branch-4.0:[feature](mtmv)MTMV refresh support multi pct tables (#58140)
1d63c19 
pick: #56958
#57713
#57759
#57681
#57958

---------

Co-authored-by: seawinde <daydayup005@yeah.net>
Co-authored-by: seawinde <wusi@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@zddr zddr zddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@seawinde @hello-stephen @doris-robot @zddr @morrySnow @yiguolei