Skip to content

[fix](mtmv)Fix multi pct multi partition cols should throws exception #57713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 3 commits into from
Nov 10, 2025
Merged

[fix](mtmv)Fix multi pct multi partition cols should throws exception #57713

morrySnow merged 3 commits into from
Nov 10, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Nov 5, 2025 •
edited
Loading

What problem does this PR solve?

add check for range table which have multi partition columns

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Nov 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 5, 2025

TPC-DS: Total hot run time: 189427 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 217ba30aa79135c933505028a849cda12193a80a, data reload: false

query1	1060	396	399	396
query2	6562	1688	1690	1688
query3	6765	227	220	220
query4	26678	24054	23515	23515
query5	5051	631	482	482
query6	359	248	235	235
query7	4657	510	307	307
query8	343	272	246	246
query9	8690	2560	2585	2560
query10	543	325	289	289
query11	15859	15035	15643	15035
query12	203	125	147	125
query13	2117	596	471	471
query14	11816	9562	9500	9500
query15	213	218	180	180
query16	7964	699	573	573
query17	2179	849	699	699
query18	2089	454	351	351
query19	281	237	186	186
query20	139	147	128	128
query21	226	147	121	121
query22	4533	4654	4466	4466
query23	34676	33885	33460	33460
query24	8368	2444	2422	2422
query25	611	531	486	486
query26	1249	274	158	158
query27	2699	487	352	352
query28	4324	2187	2209	2187
query29	783	606	473	473
query30	291	224	192	192
query31	920	812	726	726
query32	83	66	67	66
query33	615	378	323	323
query34	806	849	520	520
query35	802	825	753	753
query36	951	1018	906	906
query37	120	103	87	87
query38	3513	3563	3507	3507
query39	1466	1397	1400	1397
query40	224	137	116	116
query41	60	56	65	56
query42	119	107	114	107
query43	497	490	461	461
query44	1210	758	732	732
query45	184	177	171	171
query46	873	987	634	634
query47	1742	1793	1710	1710
query48	394	425	334	334
query49	760	533	454	454
query50	633	677	404	404
query51	3880	3883	3861	3861
query52	114	110	100	100
query53	237	262	193	193
query54	309	283	276	276
query55	85	84	80	80
query56	327	320	309	309
query57	1176	1189	1121	1121
query58	284	269	268	268
query59	2491	2714	2516	2516
query60	337	355	324	324
query61	193	197	181	181
query62	792	721	664	664
query63	229	195	196	195
query64	4511	1161	883	883
query65	4037	3936	3974	3936
query66	1086	435	351	351
query67	15243	15148	14943	14943
query68	8017	892	593	593
query69	491	320	286	286
query70	1361	1226	1314	1226
query71	476	330	311	311
query72	5958	4905	4852	4852
query73	670	574	361	361
query74	8926	9022	8787	8787
query75	3725	3443	2872	2872
query76	3607	1150	752	752
query77	786	415	321	321
query78	9648	9714	8881	8881
query79	2471	799	593	593
query80	696	555	507	507
query81	514	254	222	222
query82	488	166	131	131
query83	273	267	253	253
query84	262	110	93	93
query85	942	491	442	442
query86	391	301	301	301
query87	3732	3739	3623	3623
query88	3958	2246	2207	2207
query89	389	326	294	294
query90	1978	213	219	213
query91	164	165	136	136
query92	83	66	65	65
query93	2099	971	639	639
query94	683	418	344	344
query95	413	320	315	315
query96	482	573	280	280
query97	2906	2955	2850	2850
query98	258	217	204	204
query99	1320	1405	1305	1305
Total cold run time: 280798 ms
Total hot run time: 189427 ms

@doris-robot
Copy link

doris-robot commented Nov 5, 2025

ClickBench: Total hot run time: 27.91 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 217ba30aa79135c933505028a849cda12193a80a, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.05
query3	0.25	0.09	0.08
query4	1.61	0.11	0.11
query5	0.27	0.26	0.26
query6	1.19	0.64	0.62
query7	0.04	0.03	0.02
query8	0.05	0.04	0.05
query9	0.61	0.51	0.52
query10	0.58	0.58	0.59
query11	0.16	0.11	0.12
query12	0.16	0.11	0.12
query13	0.61	0.60	0.60
query14	1.01	1.02	1.00
query15	0.86	0.82	0.85
query16	0.39	0.39	0.43
query17	1.03	1.06	1.04
query18	0.21	0.20	0.20
query19	1.97	1.90	1.82
query20	0.01	0.01	0.01
query21	15.47	0.19	0.13
query22	5.00	0.06	0.05
query23	15.64	0.26	0.10
query24	2.68	0.90	0.93
query25	0.07	0.06	0.07
query26	0.14	0.13	0.14
query27	0.06	0.05	0.05
query28	5.57	1.16	0.93
query29	12.57	3.88	3.21
query30	0.29	0.14	0.12
query31	2.82	0.59	0.39
query32	3.24	0.55	0.46
query33	3.07	3.03	3.02
query34	15.82	5.26	4.58
query35	4.54	4.56	4.54
query36	0.67	0.50	0.49
query37	0.09	0.06	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.15	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 99.33 s
Total hot run time: 27.91 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (8/8) 🎉
Increment coverage report
Complete coverage report

@zddr
Copy link
Contributor Author

zddr commented Nov 6, 2025

run nonConcurrent

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit c6cb536 into apache:master Nov 10, 2025
32 of 34 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@zddr @wyxxxcat
[fix](mtmv)Fix multi pct multi partition cols should throws exception (…
3b16ad2 
…apache#57713)
zddr added a commit to zddr/incubator-doris that referenced this pull request Nov 19, 2025
@zddr
[fix](mtmv)Fix multi pct multi partition cols should throws exception (…
41ad6f6 
…apache#57713)
@zddr zddr mentioned this pull request Nov 19, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 20, 2025
@zddr @seawinde
branch-4.0:[feature](mtmv)MTMV refresh support multi pct tables (#58140)
1d63c19 
pick: #56958
#57713
#57759
#57681
#57958

---------

Co-authored-by: seawinde <daydayup005@yeah.net>
Co-authored-by: seawinde <wusi@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@seawinde seawinde seawinde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zddr @hello-stephen @doris-robot @morrySnow @seawinde @yiguolei