Skip to content

[Fix](Repository)Handle non-StorageException errors in Storage parameter validation #56929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Oct 15, 2025
Merged

[Fix](Repository)Handle non-StorageException errors in Storage parameter validation #56929

morningman merged 2 commits into from
Oct 15, 2025

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Oct 14, 2025

Currently, during Storage parameter validation, some unexpected exceptions (e.g., IllegalArgumentException) may be thrown in addition to StorageException.
This PR ensures that such non-StorageException errors are properly caught and handled, preventing unexpected crashes and improving robustness.

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Member Author

CalvinKirs commented Oct 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

TPC-DS: Total hot run time: 190592 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3e08402e326da7f2d6839c608ab0b01a5f5596ac, data reload: false

query1	1073	448	402	402
query2	6552	1749	1695	1695
query3	6761	222	237	222
query4	26276	23375	23269	23269
query5	5336	633	534	534
query6	344	247	223	223
query7	4653	493	304	304
query8	305	280	260	260
query9	8731	2564	2535	2535
query10	555	347	297	297
query11	15674	15113	15020	15020
query12	189	118	116	116
query13	1696	565	444	444
query14	12664	9378	9358	9358
query15	286	203	180	180
query16	7818	682	523	523
query17	1601	785	644	644
query18	2132	435	339	339
query19	277	212	183	183
query20	132	127	131	127
query21	220	142	119	119
query22	4748	4875	4618	4618
query23	35078	33925	33884	33884
query24	8558	2543	2474	2474
query25	625	532	483	483
query26	1222	283	165	165
query27	3001	539	364	364
query28	4416	2171	2170	2170
query29	819	636	504	504
query30	349	250	226	226
query31	965	939	770	770
query32	91	75	80	75
query33	697	402	324	324
query34	824	891	534	534
query35	819	819	756	756
query36	979	1005	925	925
query37	117	108	81	81
query38	3538	3573	3510	3510
query39	1448	1415	1416	1415
query40	215	137	125	125
query41	66	57	58	57
query42	118	110	107	107
query43	479	494	473	473
query44	1310	827	816	816
query45	186	180	169	169
query46	839	1005	622	622
query47	1775	1790	1696	1696
query48	398	440	306	306
query49	786	488	427	427
query50	648	689	411	411
query51	3912	3974	3901	3901
query52	112	107	103	103
query53	232	266	202	202
query54	596	586	534	534
query55	88	83	83	83
query56	311	331	314	314
query57	1179	1220	1110	1110
query58	282	270	264	264
query59	2541	2694	2510	2510
query60	344	337	322	322
query61	152	155	182	155
query62	779	715	678	678
query63	227	186	195	186
query64	4374	1141	835	835
query65	4078	3957	3996	3957
query66	1071	448	329	329
query67	15551	15315	15129	15129
query68	8967	945	591	591
query69	501	331	293	293
query70	1411	1311	1333	1311
query71	520	337	317	317
query72	5841	4870	4839	4839
query73	708	571	354	354
query74	8913	9098	8862	8862
query75	4411	3370	2886	2886
query76	3765	1153	732	732
query77	809	413	313	313
query78	9668	9788	8996	8996
query79	3436	821	583	583
query80	691	562	517	517
query81	493	271	228	228
query82	465	155	138	138
query83	288	261	286	261
query84	300	112	97	97
query85	875	467	424	424
query86	339	310	309	309
query87	3824	3777	3807	3777
query88	2938	2265	2216	2216
query89	443	329	302	302
query90	2040	214	218	214
query91	167	166	137	137
query92	84	72	68	68
query93	2168	978	646	646
query94	690	469	335	335
query95	398	317	312	312
query96	485	574	288	288
query97	2974	2978	2868	2868
query98	227	217	207	207
query99	1491	1419	1278	1278
Total cold run time: 284548 ms
Total hot run time: 190592 ms

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

ClickBench: Total hot run time: 30.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3e08402e326da7f2d6839c608ab0b01a5f5596ac, data reload: false

query1	0.06	0.04	0.05
query2	0.08	0.05	0.06
query3	0.25	0.08	0.09
query4	1.60	0.12	0.11
query5	0.28	0.28	0.25
query6	1.17	0.65	0.65
query7	0.03	0.03	0.02
query8	0.05	0.05	0.05
query9	0.62	0.53	0.54
query10	0.58	0.58	0.57
query11	0.17	0.12	0.12
query12	0.14	0.12	0.12
query13	0.62	0.61	0.62
query14	1.04	1.03	1.00
query15	0.87	0.87	0.87
query16	0.40	0.42	0.41
query17	1.04	1.04	1.04
query18	0.22	0.20	0.20
query19	1.89	1.82	1.85
query20	0.01	0.01	0.02
query21	15.44	0.92	0.59
query22	0.75	1.11	0.67
query23	15.02	1.36	0.65
query24	6.82	1.30	1.03
query25	0.57	0.31	0.12
query26	0.50	0.15	0.12
query27	0.08	0.05	0.05
query28	9.77	1.35	0.93
query29	12.57	3.94	3.28
query30	0.29	0.13	0.12
query31	2.82	0.59	0.41
query32	3.24	0.55	0.48
query33	3.05	3.11	3.04
query34	16.04	5.47	4.83
query35	4.86	4.90	4.89
query36	0.68	0.50	0.50
query37	0.10	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.02
query40	0.18	0.15	0.15
query41	0.09	0.04	0.03
query42	0.04	0.04	0.03
query43	0.04	0.03	0.04
Total cold run time: 104.17 s
Total hot run time: 30.63 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

FE Regression Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@CalvinKirs
Copy link
Member Author

CalvinKirs commented Oct 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

ClickBench: Total hot run time: 31.17 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit acd3fef13dc8d8a716a9ca6ef8690d572b9f4db0, data reload: false

query1	0.06	0.05	0.06
query2	0.09	0.05	0.06
query3	0.25	0.08	0.09
query4	1.61	0.12	0.12
query5	0.26	0.28	0.26
query6	1.17	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.62	0.54	0.52
query10	0.58	0.61	0.58
query11	0.17	0.11	0.11
query12	0.15	0.12	0.12
query13	0.64	0.62	0.64
query14	1.04	1.02	1.04
query15	0.88	0.87	0.87
query16	0.39	0.42	0.42
query17	1.04	1.11	1.05
query18	0.22	0.21	0.21
query19	1.94	1.83	1.87
query20	0.02	0.02	0.01
query21	15.44	0.93	0.58
query22	0.77	1.20	0.64
query23	14.93	1.38	0.60
query24	6.62	1.56	1.25
query25	0.45	0.24	0.21
query26	0.55	0.16	0.13
query27	0.07	0.06	0.05
query28	10.27	1.33	0.97
query29	12.60	3.92	3.27
query30	0.28	0.15	0.11
query31	2.83	0.60	0.40
query32	3.25	0.57	0.49
query33	3.18	3.09	3.13
query34	16.13	5.51	4.90
query35	5.02	4.95	4.95
query36	0.70	0.52	0.50
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 104.87 s
Total hot run time: 31.17 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

FE Regression Coverage Report

Increment line coverage 0.00% (0/5) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 15, 2025

FE Regression Coverage Report

Increment line coverage 0.00% (0/5) 🎉
Increment coverage report
Complete coverage report

@morningman morningman merged commit e138c3e into apache:master Oct 15, 2025
27 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
@CalvinKirs
[Fix](Repository)Handle non-StorageException errors in Storage parame…
22b7131 
…ter validation (#56929)

Currently, during Storage parameter validation, some unexpected
exceptions (e.g., IllegalArgumentException) may be thrown in addition to
StorageException.
This PR ensures that such non-StorageException errors are properly
caught and handled, preventing unexpected crashes and improving
robustness.
@github-actions github-actions bot mentioned this pull request Oct 15, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
@CalvinKirs
[Fix](Repository)Handle non-StorageException errors in Storage parame…
6068853 
…ter validation (#56929)

Currently, during Storage parameter validation, some unexpected
exceptions (e.g., IllegalArgumentException) may be thrown in addition to
StorageException.
This PR ensures that such non-StorageException errors are properly
caught and handled, preventing unexpected crashes and improving
robustness.
@github-actions github-actions bot mentioned this pull request Oct 15, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 16, 2025
@github-actions @CalvinKirs
branch-4.0: [Fix](Repository)Handle non-StorageException errors in St…
ac76237 
…orage parameter validation #56929 (#57015)

Cherry-picked from #56929

Co-authored-by: Calvin Kirs <guoqiang@selectdb.com>
morrySnow pushed a commit that referenced this pull request Oct 17, 2025
@github-actions @CalvinKirs @morningman
branch-3.1: [Fix](Repository)Handle non-StorageException errors in St…
0a91a31 
…orage parameter validation #56929 (#57014)

Cherry-picked from #56929

---------

Co-authored-by: Calvin Kirs <guoqiang@selectdb.com>
Co-authored-by: Mingyu Chen (Rayner) <yunyou@selectdb.com>
@CalvinKirs CalvinKirs deleted the master-test branch October 28, 2025 06:38
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CalvinKirs @hello-stephen @doris-robot @morningman @zy-kkk @yiguolei @morrySnow