Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #56929

…ter validation (#56929)

Currently, during Storage parameter validation, some unexpected
exceptions (e.g., IllegalArgumentException) may be thrown in addition to
StorageException.
This PR ensures that such non-StorageException errors are properly
caught and handled, preventing unexpected crashes and improving
robustness.
@github-actions github-actions bot requested a review from yiguolei as a code owner October 15, 2025 15:43
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 15, 2025
@hello-stephen
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

ClickBench: Total hot run time: 29.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6068853ce1caa2a124150cebcf40ef04d3a2a10b, data reload: true

query1	0.03	0.03	0.03
query2	0.11	0.04	0.04
query3	0.28	0.07	0.07
query4	1.75	0.11	0.11
query5	0.27	0.24	0.25
query6	1.24	0.65	0.64
query7	0.02	0.02	0.02
query8	0.06	0.03	0.03
query9	0.64	0.52	0.53
query10	0.58	0.57	0.57
query11	0.17	0.10	0.11
query12	0.16	0.11	0.11
query13	0.64	0.62	0.61
query14	0.79	0.83	0.82
query15	0.88	0.85	0.84
query16	0.41	0.40	0.41
query17	1.07	1.08	1.03
query18	0.20	0.19	0.19
query19	1.92	1.85	1.81
query20	0.02	0.01	0.02
query21	15.45	0.91	0.57
query22	0.83	1.01	0.78
query23	15.20	1.34	0.60
query24	16.29	0.48	0.16
query25	0.15	0.08	0.05
query26	0.37	0.16	0.13
query27	0.06	0.05	0.04
query28	10.73	0.96	0.93
query29	12.72	3.88	3.22
query30	0.31	0.13	0.11
query31	3.00	0.58	0.39
query32	3.33	0.56	0.49
query33	3.02	3.02	3.10
query34	17.83	5.85	5.04
query35	5.18	5.08	5.13
query36	0.72	0.56	0.52
query37	0.11	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.09	0.03	0.02
query42	0.05	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 116.99 s
Total hot run time: 29.67 s

@yiguolei yiguolei merged commit ac76237 into branch-4.0 Oct 16, 2025
25 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-56929-branch-4.0 branch October 16, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants