Skip to content

branch-3.1: [Fix](Repository)Handle non-StorageException errors in Storage parameter validation #56929 #57014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Oct 17, 2025
Merged

branch-3.1: [Fix](Repository)Handle non-StorageException errors in Storage parameter validation #56929 #57014

morrySnow merged 2 commits into from
Oct 17, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 15, 2025

Cherry-picked from #56929

@CalvinKirs
[Fix](Repository)Handle non-StorageException errors in Storage parame…
22b7131 
…ter validation (#56929)

Currently, during Storage parameter validation, some unexpected
exceptions (e.g., IllegalArgumentException) may be thrown in addition to
StorageException.
This PR ensures that such non-StorageException errors are properly
caught and handled, preventing unexpected crashes and improving
robustness.
@github-actions github-actions bot requested a review from morrySnow as a code owner October 15, 2025 15:42
@Thearas
Copy link
Contributor

Thearas commented Oct 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 15, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

TPC-H: Total hot run time: 32493 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 22b7131c4ab82939cd7c0a0866ca08b94b420ff7, data reload: false

------ Round 1 ----------------------------------
q1	17596	5458	5438	5438
q2	2032	402	266	266
q3	12107	1240	751	751
q4	10561	871	459	459
q5	9636	2370	2139	2139
q6	196	165	133	133
q7	904	765	620	620
q8	9333	1443	1140	1140
q9	5171	4912	4906	4906
q10	6729	2274	1811	1811
q11	472	289	266	266
q12	337	350	208	208
q13	17789	3557	2993	2993
q14	239	218	221	218
q15	506	461	465	461
q16	414	415	369	369
q17	605	849	366	366
q18	6784	6421	6318	6318
q19	1225	966	523	523
q20	342	337	217	217
q21	2767	2134	1918	1918
q22	1049	1021	973	973
Total cold run time: 106794 ms
Total hot run time: 32493 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5515	5486	5542	5486
q2	239	327	231	231
q3	2272	2606	2322	2322
q4	1329	1796	1356	1356
q5	4357	4915	4951	4915
q6	170	167	135	135
q7	2117	2012	1807	1807
q8	2635	2834	2657	2657
q9	7184	7176	7171	7171
q10	3052	3223	2798	2798
q11	578	501	524	501
q12	644	744	625	625
q13	3370	3747	3126	3126
q14	300	303	282	282
q15	505	465	460	460
q16	450	493	438	438
q17	1221	1735	1270	1270
q18	7639	7426	7366	7366
q19	809	1170	1084	1084
q20	1999	2029	1931	1931
q21	5391	4847	4479	4479
q22	1084	1046	1021	1021
Total cold run time: 52860 ms
Total hot run time: 51461 ms

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

TPC-DS: Total hot run time: 192354 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 22b7131c4ab82939cd7c0a0866ca08b94b420ff7, data reload: false

query1	947	401	417	401
query2	6190	1933	1863	1863
query3	8680	204	205	204
query4	33853	23726	23985	23726
query5	4234	617	451	451
query6	282	199	186	186
query7	4215	498	317	317
query8	294	245	234	234
query9	9441	2615	2604	2604
query10	491	323	261	261
query11	18157	15385	15292	15292
query12	152	109	108	108
query13	1553	535	426	426
query14	9538	7068	6693	6693
query15	238	186	174	174
query16	8082	624	483	483
query17	1544	758	584	584
query18	2115	409	321	321
query19	218	179	169	169
query20	120	121	117	117
query21	208	131	102	102
query22	4425	4763	4398	4398
query23	34844	34092	34474	34092
query24	7297	2708	2709	2708
query25	580	529	460	460
query26	797	294	172	172
query27	2057	491	365	365
query28	5337	2231	2213	2213
query29	698	602	479	479
query30	245	193	166	166
query31	957	914	871	871
query32	89	57	63	57
query33	495	367	342	342
query34	748	880	540	540
query35	793	817	739	739
query36	1019	1066	978	978
query37	109	103	72	72
query38	3987	3993	3959	3959
query39	1513	1487	1494	1487
query40	212	117	104	104
query41	51	46	46	46
query42	133	110	110	110
query43	506	522	485	485
query44	1322	836	827	827
query45	188	180	174	174
query46	896	1071	674	674
query47	1961	1974	1904	1904
query48	461	430	352	352
query49	737	488	424	424
query50	669	685	433	433
query51	7452	7311	7204	7204
query52	102	98	100	98
query53	235	259	199	199
query54	561	562	487	487
query55	91	87	81	81
query56	280	277	250	250
query57	1299	1286	1200	1200
query58	245	214	214	214
query59	3134	3243	3130	3130
query60	301	287	265	265
query61	123	115	111	111
query62	798	740	724	724
query63	233	206	193	193
query64	3778	1030	640	640
query65	3384	3254	3299	3254
query66	801	414	308	308
query67	16177	15863	15551	15551
query68	7710	818	557	557
query69	485	301	264	264
query70	1245	1107	1083	1083
query71	370	300	278	278
query72	5723	3819	3876	3819
query73	645	748	360	360
query74	10289	9101	8944	8944
query75	3254	3126	2684	2684
query76	3084	1173	758	758
query77	506	365	274	274
query78	10292	10291	9540	9540
query79	3035	893	600	600
query80	634	508	443	443
query81	506	250	222	222
query82	569	119	89	89
query83	179	163	145	145
query84	242	104	78	78
query85	768	389	314	314
query86	343	318	296	296
query87	4382	4267	4366	4267
query88	5052	2436	2405	2405
query89	413	333	296	296
query90	1850	185	189	185
query91	139	142	105	105
query92	65	55	49	49
query93	1824	871	552	552
query94	684	415	307	307
query95	352	276	273	273
query96	494	598	280	280
query97	3171	3221	3128	3128
query98	225	206	208	206
query99	1492	1420	1297	1297
Total cold run time: 292694 ms
Total hot run time: 192354 ms

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

ClickBench: Total hot run time: 29.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 22b7131c4ab82939cd7c0a0866ca08b94b420ff7, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.11	0.10
query5	0.52	0.52	0.52
query6	1.13	0.74	0.73
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.57	0.50	0.52
query10	0.55	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.62
query14	0.77	0.80	0.78
query15	0.85	0.83	0.82
query16	0.41	0.40	0.40
query17	1.00	1.07	1.04
query18	0.23	0.23	0.23
query19	1.86	1.74	1.77
query20	0.02	0.01	0.01
query21	15.41	0.94	0.59
query22	0.74	0.79	0.60
query23	15.19	1.39	0.60
query24	3.35	1.53	1.17
query25	0.15	0.17	0.05
query26	0.28	0.16	0.13
query27	0.04	0.05	0.03
query28	13.50	0.98	0.43
query29	12.66	3.90	3.28
query30	0.26	0.09	0.06
query31	2.82	0.58	0.38
query32	3.22	0.54	0.46
query33	2.99	3.01	3.01
query34	16.69	5.16	4.55
query35	4.56	4.51	4.60
query36	0.65	0.49	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 103.84 s
Total hot run time: 29.05 s

morrySnow
morrySnow previously approved these changes Oct 16, 2025
View reviewed changes
@morningman
Copy link
Contributor

morningman commented Oct 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

TPC-H: Total hot run time: 32872 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d7c100980e79e2a520de0b88a508a0659a9eeaad, data reload: false

------ Round 1 ----------------------------------
q1	17576	5456	5484	5456
q2	2047	294	160	160
q3	10437	1286	741	741
q4	10206	881	475	475
q5	7680	2423	2144	2144
q6	183	174	138	138
q7	918	765	639	639
q8	9360	1458	1239	1239
q9	5371	4985	4939	4939
q10	6767	2272	1811	1811
q11	489	288	273	273
q12	342	359	220	220
q13	17793	3632	3059	3059
q14	227	231	220	220
q15	537	482	464	464
q16	406	427	379	379
q17	591	868	379	379
q18	6926	6481	6291	6291
q19	1199	954	584	584
q20	340	340	205	205
q21	3050	2331	2062	2062
q22	1024	1043	994	994
Total cold run time: 103469 ms
Total hot run time: 32872 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5555	5499	5519	5499
q2	229	338	227	227
q3	2236	2631	2327	2327
q4	1422	1870	1420	1420
q5	4425	4881	5115	4881
q6	171	163	131	131
q7	2044	1999	1797	1797
q8	2639	2814	2662	2662
q9	7198	7182	7089	7089
q10	3032	3298	2849	2849
q11	575	509	488	488
q12	633	735	565	565
q13	3500	3785	3171	3171
q14	280	302	275	275
q15	529	462	477	462
q16	444	514	452	452
q17	1231	1725	1266	1266
q18	7584	7475	7216	7216
q19	814	910	1056	910
q20	2003	2061	1902	1902
q21	5332	4961	4806	4806
q22	1107	1115	1035	1035
Total cold run time: 52983 ms
Total hot run time: 51430 ms

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

TPC-DS: Total hot run time: 190756 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d7c100980e79e2a520de0b88a508a0659a9eeaad, data reload: false

query1	966	398	393	393
query2	6531	2020	1949	1949
query3	6707	220	226	220
query4	33917	23746	23457	23457
query5	4377	613	467	467
query6	277	193	194	193
query7	4633	492	314	314
query8	308	254	243	243
query9	9611	2618	2607	2607
query10	485	330	269	269
query11	18333	15397	15617	15397
query12	161	103	101	101
query13	1645	542	413	413
query14	10003	7197	6646	6646
query15	234	199	190	190
query16	8135	656	514	514
query17	1709	751	602	602
query18	2149	419	332	332
query19	228	191	181	181
query20	118	114	113	113
query21	207	134	118	118
query22	4512	4537	4546	4537
query23	35608	33626	33272	33272
query24	7257	2616	2623	2616
query25	447	445	408	408
query26	1160	251	166	166
query27	2043	465	347	347
query28	5201	2172	2121	2121
query29	553	539	428	428
query30	251	183	171	171
query31	947	886	812	812
query32	87	61	57	57
query33	503	365	296	296
query34	731	820	495	495
query35	776	790	696	696
query36	1014	1060	954	954
query37	98	90	66	66
query38	3899	3846	3816	3816
query39	1482	1460	1468	1460
query40	204	128	101	101
query41	49	47	46	46
query42	115	104	108	104
query43	514	515	489	489
query44	1257	790	796	790
query45	181	174	166	166
query46	865	1038	662	662
query47	1889	1928	1851	1851
query48	420	422	341	341
query49	769	491	411	411
query50	649	679	416	416
query51	7247	7315	7089	7089
query52	107	107	97	97
query53	227	250	185	185
query54	534	540	457	457
query55	82	80	87	80
query56	277	268	255	255
query57	1214	1218	1191	1191
query58	239	220	220	220
query59	3039	3226	2984	2984
query60	295	294	278	278
query61	135	136	131	131
query62	816	740	692	692
query63	225	199	192	192
query64	4585	1069	729	729
query65	3293	3214	3225	3214
query66	1098	462	325	325
query67	16071	15846	15724	15724
query68	4842	843	567	567
query69	492	323	283	283
query70	1214	1126	1095	1095
query71	376	302	268	268
query72	5671	3769	3800	3769
query73	639	734	363	363
query74	10629	9475	8951	8951
query75	3174	3152	2650	2650
query76	3160	1181	776	776
query77	528	366	301	301
query78	10348	10454	9585	9585
query79	3632	897	597	597
query80	773	521	436	436
query81	510	257	229	229
query82	642	123	92	92
query83	193	174	154	154
query84	295	116	86	86
query85	787	357	317	317
query86	402	310	287	287
query87	4342	4293	4201	4201
query88	5145	2386	2382	2382
query89	398	337	303	303
query90	1924	186	185	185
query91	140	138	113	113
query92	62	56	53	53
query93	2442	897	552	552
query94	704	414	311	311
query95	345	278	275	275
query96	483	607	295	295
query97	3172	3300	3117	3117
query98	226	219	197	197
query99	1506	1442	1309	1309
Total cold run time: 292895 ms
Total hot run time: 190756 ms

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

ClickBench: Total hot run time: 29.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d7c100980e79e2a520de0b88a508a0659a9eeaad, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.06
query4	1.63	0.10	0.11
query5	0.53	0.50	0.52
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.02
query9	0.57	0.50	0.50
query10	0.55	0.56	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.64	0.61	0.59
query14	0.79	0.81	0.80
query15	0.87	0.86	0.85
query16	0.39	0.39	0.42
query17	1.08	1.05	1.02
query18	0.25	0.23	0.24
query19	1.87	1.86	1.75
query20	0.02	0.01	0.01
query21	15.40	0.91	0.59
query22	0.74	0.79	0.60
query23	15.13	1.43	0.60
query24	3.52	1.57	1.17
query25	0.15	0.16	0.04
query26	0.29	0.15	0.14
query27	0.08	0.04	0.04
query28	13.39	1.05	0.44
query29	12.56	3.99	3.24
query30	0.26	0.08	0.06
query31	2.83	0.59	0.40
query32	3.23	0.56	0.50
query33	3.07	3.00	3.09
query34	16.76	5.37	4.64
query35	4.62	4.64	4.65
query36	0.62	0.49	0.50
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.03	0.02	0.03
Total cold run time: 104.15 s
Total hot run time: 29.27 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 0a91a31 into branch-3.1 Oct 17, 2025
24 of 26 checks passed
@github-actions github-actions bot deleted the auto-pick-56929-branch-3.1 branch October 17, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Thearas @doris-robot @morningman @hello-stephen @morrySnow @dataroaring @CalvinKirs